Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: cleanup gmpy[2], add phe #46126

Merged
merged 3 commits into from Sep 6, 2018
Merged

pythonPackages: cleanup gmpy[2], add phe #46126

merged 3 commits into from Sep 6, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 5, 2018

Motivation for this change

This cleans up the gmpy, and gmpy2 python packages and moves them into separate files.
Additionally, this adds phe, a library for Partially Homomorphic Encryption in Python".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from FRidh as a code owner September 5, 2018 21:49
@srhb
Copy link
Contributor

srhb commented Sep 6, 2018

@GrahamcOfBorg build pythonPackages.phe pythonPackages.gmpy pythonPackages.gmpy2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.gmpy, pythonPackages.gmpy2

The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.phe

Partial log (click to expand)

 __MPFR_DECLSPEC int mpfr_root (mpfr_ptr, mpfr_srcptr, unsigned long,
                     ^~~~~~~~~
gcc -pthread -shared -lgcc_s build/temp.linux-x86_64-2.7/src/gmpy2.o -L/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/lib -lgmp -lmpfr -lmpc -lpython2.7 -o /build/gmpy2-2.0.8/gmpy2.so

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ji6avg64m8q289ixix9zwx5xr7r60yrx-python2.7-gmpy-1.17
/nix/store/7b120xr2fid9hir980i4n2v8agd6rdmq-python2.7-gmpy2-2.0.8

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.gmpy, pythonPackages.gmpy2

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.phe

Partial log (click to expand)

                                         ^
2 warnings generated.
clang -bundle -undefined dynamic_lookup build/temp.macosx-10.10-x86_64-2.7/src/gmpy2.o -L/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/lib -lgmp -lmpfr -lmpc -o /private/tmp/nix-build-python2.7-gmpy2-2.0.8.drv-0/gmpy2-2.0.8/gmpy2.so

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ws7scskwl981dxdznjzrjsjz5i3n8s4m-python2.7-gmpy-1.17
/nix/store/rwgnwksv2nrhax1lf3yy29pnwp5b09ha-python2.7-gmpy2-2.0.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.gmpy, pythonPackages.gmpy2

The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.phe

Partial log (click to expand)

 __MPFR_DECLSPEC int mpfr_root (mpfr_ptr, mpfr_srcptr, unsigned long,
                     ^~~~~~~~~
gcc -pthread -shared -lgcc_s build/temp.linux-aarch64-2.7/src/gmpy2.o -L/nix/store/imv54r70hay2sjrbjiw9l5hhmq3zdkkx-python-2.7.15/lib -lgmp -lmpfr -lmpc -lpython2.7 -o /build/gmpy2-2.0.8/gmpy2.so

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/x53vvlf21yziy6slp4y29hqfabk6mx50-python2.7-gmpy-1.17
/nix/store/v8063g1p8fag87pldcb2xmfg89sb89xl-python2.7-gmpy2-2.0.8

@srhb
Copy link
Contributor

srhb commented Sep 6, 2018

@GrahamcOfBorg build python3Packages.phe

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.phe

Partial log (click to expand)

Successfully installed phe-1.4.0
/build/phe-1.4.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0/lib  /nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0/bin
patching script interpreter paths in /nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0
checking for references to /build in /nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0...
wrapping `/nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0/bin/pheutil'...
/nix/store/8452pfnqhyc88is6bjvh3lm6bmiwh4jg-python3.6-phe-1.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.phe

Partial log (click to expand)

  The script pheutil is installed in '/nix/store/hc5ca22pc7skjkk8b7g4h4bpfq3lcxcx-python3.6-phe-1.4.0/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed phe-1.4.0
/private/tmp/nix-build-python3.6-phe-1.4.0.drv-0/phe-1.4.0
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hc5ca22pc7skjkk8b7g4h4bpfq3lcxcx-python3.6-phe-1.4.0/lib  /nix/store/hc5ca22pc7skjkk8b7g4h4bpfq3lcxcx-python3.6-phe-1.4.0/bin
patching script interpreter paths in /nix/store/hc5ca22pc7skjkk8b7g4h4bpfq3lcxcx-python3.6-phe-1.4.0
wrapping `/nix/store/hc5ca22pc7skjkk8b7g4h4bpfq3lcxcx-python3.6-phe-1.4.0/bin/pheutil'...
/nix/store/hc5ca22pc7skjkk8b7g4h4bpfq3lcxcx-python3.6-phe-1.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.phe

Partial log (click to expand)

Successfully installed phe-1.4.0
/build/phe-1.4.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0/lib  /nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0/bin
patching script interpreter paths in /nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0
checking for references to /build in /nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0...
wrapping `/nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0/bin/pheutil'...
/nix/store/x8sibx4vrnra2niawl827h7852dn8xc8-python3.6-phe-1.4.0

@srhb
Copy link
Contributor

srhb commented Sep 6, 2018

Thanks!

@srhb srhb merged commit a59f244 into NixOS:master Sep 6, 2018
@flokli flokli deleted the gmpy-phe branch September 6, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @srhb @GrahamcOfBorg