Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nullidentdmod: Init #46144

Merged
merged 1 commit into from Sep 16, 2018
Merged

nixos/nullidentdmod: Init #46144

merged 1 commit into from Sep 16, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Sep 6, 2018

Motivation for this change

To properly use the package, systemd units are required - hence the module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 6, 2018
View reviewed changes
nixos/modules/services/networking/nullidentdmod.nix Outdated
systemd.services."nullidentdmod@" = {
description = "NullidentdMod service";
serviceConfig = {
User = "nobody";
Copy link
Member

@Mic92 Mic92 Sep 6, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use DynamicUser=true instead of nobody. Are you sue that nullidentdmod.sockets starts nullidentdmod@ and not nullidentdmod?

Mic92
Mic92 reviewed Sep 6, 2018
View reviewed changes
nixos/modules/services/networking/nullidentdmod.nix Outdated
};
};

networking.firewall.allowedTCPPorts = [ 113 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to not open firewall ports automatically except for ssh: #19504

@dasJ
Copy link
Member Author

dasJ commented Sep 6, 2018

@Mic92 Fixed

@dasJ
Copy link
Member Author

dasJ commented Sep 16, 2018

@Mic92 ping

@Mic92 Mic92 merged commit fc41ea8 into NixOS:master Sep 16, 2018
@dasJ dasJ deleted the nullidentdmod-module branch November 6, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @Mic92 @GrahamcOfBorg