Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: add alternative url for the source code #46145

Merged
merged 2 commits into from Sep 6, 2018
Merged

gildas: add alternative url for the source code #46145

merged 2 commits into from Sep 6, 2018

Conversation

smaret
Copy link
Member

@smaret smaret commented Sep 6, 2018

Motivation for this change

For each new release, the upstream developers of Gildas move the source code of the previous release to a different directory. Add this directory to the list of url to avoid build failure at each new
release.

Please cherry-pick to 18.09 when merging.

/cc #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@smaret
gildas: add alternative url for the source code
5aff08e 
For each new release, the upstream developers of Gildas move the
source code of the previous release to a different directory. Add this
directory to the list of url to avoid build failure at each new
release.
@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

@GrahamcOfBorg build gildas

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gildas

Partial log (click to expand)

copying path '/nix/store/j81z6kp9b5q85v5xirv786q5lnzcv14g-libXcomposite-0.4.4' from 'https://cache.nixos.org'...
copying path '/nix/store/n8iam5q5wrsxvg8bfj9d9xg4pz5bg4db-gdk-pixbuf-2.36.12' from 'https://cache.nixos.org'...
copying path '/nix/store/a40rnybsv5lzvffsik7gzi9fcd8jywf5-libXcursor-1.1.15' from 'https://cache.nixos.org'...
copying path '/nix/store/sz4wl7sxw1q118hr5dkmvgrgi8wh3931-libXdamage-1.1.4' from 'https://cache.nixos.org'...
copying path '/nix/store/9gqbl1w4grib1llhy6zxax75zg499g2w-libXi-1.7.9' from 'https://cache.nixos.org'...
copying path '/nix/store/c1m7khqfg6ywk45lyc1frx0m9q02b0in-libXrandr-1.5.1' from 'https://cache.nixos.org'...
copying path '/nix/store/dban8pbd5zbzc3nqjkkky7lz3qm8v6n5-python-2.7.15-env' from 'https://cache.nixos.org'...
copying path '/nix/store/ak332hpkmnrbfsvr4702vk9n8xlgz5kj-gtk+-2.24.32' from 'https://cache.nixos.org'...
copying path '/nix/store/8ls62k9lm45ysy4yry5csy0czadm3nh8-gildas-20180801_a' from 'https://cache.nixos.org'...
/nix/store/8ls62k9lm45ysy4yry5csy0czadm3nh8-gildas-20180801_a

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gildas

Partial log (click to expand)

copying path '/nix/store/wqaz7as6ka8az0af0ln6526mh5j3zpny-harfbuzz-1.8.8' from 'https://cache.nixos.org'...
copying path '/nix/store/lqvm9v7f5ah5wxhpwcx59h6hh1f3vigz-libusb-1.0.22' from 'https://cache.nixos.org'...
copying path '/nix/store/bphci20w7xm0h1mjghfg2r6m69q3zm39-python-2.7.15-env' from 'https://cache.nixos.org'...
copying path '/nix/store/c4gfdlr7lyn9nzqygaa8f6fkkaw565kd-avahi-0.7' from 'https://cache.nixos.org'...
copying path '/nix/store/2rafsmql17xfvd871zawrh3jsb4fgr4y-pango-1.42.1' from 'https://cache.nixos.org'...
copying path '/nix/store/gwk2iwphfpclvk44naqxbmwv1y91fp3w-cups-2.2.6-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/dxbr1z2syvfl23x5vgnwhfjpcbij6lig-cups-2.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/06d5gpdx7ix1i6lp8sj9i2i4s3vd6qd6-gtk+-2.24.32' from 'https://cache.nixos.org'...
copying path '/nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a' from 'https://cache.nixos.org'...
/nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gildas

Partial log (click to expand)

these paths will be fetched (15.11 MiB download, 206.70 MiB unpacked):
  /nix/store/1a4qy9vygrh7c08a2xh9arw3lpivyi3d-python-2.7.15-env
  /nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a
  /nix/store/vh6lk0v5n0sw9aql2zlws9xsp259c16s-cfitsio-3.430
copying path '/nix/store/vh6lk0v5n0sw9aql2zlws9xsp259c16s-cfitsio-3.430' from 'https://cache.nixos.org'...
copying path '/nix/store/1a4qy9vygrh7c08a2xh9arw3lpivyi3d-python-2.7.15-env' from 'https://cache.nixos.org'...
copying path '/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a' from 'https://cache.nixos.org'...
/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a

@Mic92 Mic92 merged commit 5b58c6a into NixOS:master Sep 6, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

[detached HEAD 0ba0f15] gildas: add alternative url for the source code (#46145)
Author: Sebastien Maret sebastien.maret@icloud.com
Date: Thu Sep 6 16:10:21 2018 +0200
1 file changed, 4 insertions(+), 1 deletion(-)

Mic92 pushed a commit that referenced this pull request Sep 6, 2018
@smaret @Mic92
gildas: add alternative url for the source code (#46145)
0ba0f15 
For each new release, the upstream developers of Gildas move the
source code of the previous release to a different directory. Add this
directory to the list of url to avoid build failure at each new
release.

(cherry picked from commit 5b58c6a)
@smaret
Copy link
Member Author

smaret commented Sep 6, 2018

Thanks @Mic92

@smaret smaret deleted the gildas-fix-source-url branch September 6, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smaret @Mic92 @GrahamcOfBorg