heroku: 5.6.32 -> 7.16.0 #46804

bobvanderlinden · 2018-09-17T20:28:22Z

Motivation for this change

This is an alternative implementation of heroku 7.16.0 from #42869. This was inspired by @jdxcode's suggestion to use the same method as brew: using the tarball of heroku that contains all required nodejs files, except for the nodejs executable itself.

See the suggestion here: #42869 (comment)

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

jdx · 2018-09-17T20:42:46Z

pkgs/development/tools/heroku/default.nix

  '';
+
+  meta = {
+    homepage = https://toolbelt.heroku.com;


should be cli.heroku.com (though this does redirect to the same place, we just don't use the "toolbelt" brand anymore)

@jdxcode do you have any dynamically binaries in your command line or do you intend do so in future?

nope, just js files

jdx · 2018-09-17T20:44:11Z

looks great aside from the toolbelt.heroku.com URL. If you would like we could add instructions to our docs on installing the CLI in nixos

Mic92 · 2018-09-17T21:21:29Z

We should also backport this. The old version was broken afaik.

Mic92 · 2018-09-17T21:40:27Z

backport:

[detached HEAD 1934cbb] heroku: 5.6.32 -> 7.16.0
Author: Bob van der Linden bobvanderlinden@gmail.com
Date: Mon Sep 17 22:23:44 2018 +0200
2 files changed, 32 insertions(+), 71 deletions(-)
rewrite pkgs/development/tools/heroku/default.nix (86%)
[detached HEAD c922f7b] heroku: skip build phase
Author: Bob van der Linden bobvanderlinden@gmail.com
Date: Mon Sep 17 22:33:52 2018 +0200
1 file changed, 2 insertions(+)
[detached HEAD 4ba68be] heroku: set HEROKU_DISABLE_AUTOUPDATE=1
Author: Bob van der Linden bobvanderlinden@gmail.com
Date: Mon Sep 17 22:34:45 2018 +0200
1 file changed, 2 insertions(+), 1 deletion(-)
[detached HEAD 0ad7d4f] heroku: fix homepage
Date: Mon Sep 17 22:38:22 2018 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Mic92 · 2018-09-17T21:59:28Z

@jdxcode regarding upstream documentation:

nix-env -iA heroku

will install the toolchain into the user's own profile (its own packages). This will also work on macOS. 18.09, which we release start of next month would be recommended for this, as the current release contains an outdated version. In future we can back port the cli more frequently to stable releases since updating is now less of a hassle.

bobvanderlinden added 3 commits September 17, 2018 22:23

heroku: 5.6.32 -> 7.16.0

6ab1ee4

heroku: skip build phase

1f8dc21

heroku: set HEROKU_DISABLE_AUTOUPDATE=1

db571e9

bobvanderlinden mentioned this pull request Sep 17, 2018

heroku: 3.43.16 -> 7.5.7 #42869

Closed

jdx reviewed Sep 17, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 17, 2018

Mic92 merged commit 14d646e into NixOS:master Sep 17, 2018

bobvanderlinden deleted the pr-heroku-7.16.0 branch September 22, 2018 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

heroku: 5.6.32 -> 7.16.0 #46804

heroku: 5.6.32 -> 7.16.0 #46804

bobvanderlinden commented Sep 17, 2018

jdx Sep 17, 2018

Mic92 Sep 17, 2018

jdx Sep 17, 2018

Mic92 Sep 17, 2018

jdx commented Sep 17, 2018

Mic92 commented Sep 17, 2018

Mic92 commented Sep 17, 2018

Mic92 commented Sep 17, 2018 •

edited

heroku: 5.6.32 -> 7.16.0 #46804

heroku: 5.6.32 -> 7.16.0 #46804

Conversation

bobvanderlinden commented Sep 17, 2018

Motivation for this change

Things done

jdx Sep 17, 2018

Choose a reason for hiding this comment

Mic92 Sep 17, 2018

Choose a reason for hiding this comment

jdx Sep 17, 2018

Choose a reason for hiding this comment

Mic92 Sep 17, 2018

Choose a reason for hiding this comment

jdx commented Sep 17, 2018

Mic92 commented Sep 17, 2018

Mic92 commented Sep 17, 2018

Mic92 commented Sep 17, 2018 • edited

Mic92 commented Sep 17, 2018 •

edited