nixos/testing: disallow special chars in machine names in network expressions #46806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These names are referenced by Perl variables inside the testing
frameworks which don't allow
-
as character inside. An exemplaryexpression may look like this:
This expression evaluates, e.g. when running
nixos-build-vms
, but whentrying to run
./result/bin/nixos-run-vms
, an error like this occurs:This can be very confusing for beginners, this change breaks evaluation
if such names are used for machines.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)