Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading docs: easier to copy + link to issue #2429

Closed
wants to merge 3 commits into from

Conversation

ariutta
Copy link
Contributor

@ariutta ariutta commented Sep 17, 2018

With command, it's easy for users to accidentally copy the period after the command.

With `command`, it's easy for users to accidentally copy the period after the command.
@ariutta
Copy link
Contributor Author

ariutta commented Sep 17, 2018

This is relevant to #2410.

Multi-user Nix users on macOS can upgrade Nix by running this:
<screen>$ sudo -i sh -c 'nix-channel --update &amp;&amp; nix-env
-iA nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo
launchctl start org.nixos.nix-daemon</screen>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep <command> but I don't mind dropping the period, and switching to the running this: part.

<para>
Single-user installations of Nix should run this:
<screen>$ nix-channel
--update; nix-env -iA nixpkgs.nix</screen>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably stick to <command> and drop the $ prompt.

</para>

<para>
Single-user installations of Nix should run <command>nix-channel
--update; nix-env -iA nixpkgs.nix</command>.
For more information, see <link xlink:href="https://github.com/NixOS/nix/issues/2410">Issue #2410</link>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep both the old, and the new link as separate paragraphs.

Copy link
Contributor Author

@ariutta ariutta Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree they should be separate. Is the diff viewer displaying this incorrectly?

@ariutta ariutta changed the title Upgrading docs: command -> screen & more info link Upgrading docs: easier to copy + link to issue Sep 17, 2018
-iA nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo
launchctl start org.nixos.nix-daemon</command>.
-iA nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo
launchctl start org.nixos.nix-daemon</command>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually reload the service and start the new version? I think this might explain an upgrade issue I noticed yesterday.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what it's supposed to do. I've heard of two issues:

  1. If you have a package installed that depends on nix version 1.x, the updated version 2.x might not take over.
  2. For a multi-user installation, you shouldn't install nix as the current user.

@grahamc
Copy link
Member

grahamc commented Sep 19, 2018

I included much of this in PR #2434, thank you

@grahamc grahamc closed this Sep 19, 2018
@ariutta ariutta deleted the patch-1 branch October 11, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants