Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkspellmm: 3.0.4 -> 3.0.5 #46790

Merged
merged 1 commit into from Sep 17, 2018
Merged

gtkspellmm: 3.0.4 -> 3.0.5 #46790

merged 1 commit into from Sep 17, 2018

Conversation

teto
Copy link
Member

@teto teto commented Sep 17, 2018 •
edited

Archive extension changed from tar.gz to tar.xz so be careful !

Motivation for this change

gImageReader requires a version >= 3.0.5

Things done

Added file dependency to make a configure warning go away.
Also moved version field inside the attrset so that it can be overriden.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018

Did you mean gtkspellmm?

@teto teto changed the title gtkmyspell: 3.0.4 -> 3.0.5 gtkspellmm: 3.0.4 -> 3.0.5 Sep 17, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gtkspellmm

Partial log (click to expand)

make[1]: Leaving directory '/build/gtkspellmm-3.0.5'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pp12na2xyfm7p9nallmy7hyz0sx68yhs-gtkspellmm-3.0.5
shrinking /nix/store/pp12na2xyfm7p9nallmy7hyz0sx68yhs-gtkspellmm-3.0.5/lib/libgtkspellmm-3.0.so.0.2.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pp12na2xyfm7p9nallmy7hyz0sx68yhs-gtkspellmm-3.0.5/lib
patching script interpreter paths in /nix/store/pp12na2xyfm7p9nallmy7hyz0sx68yhs-gtkspellmm-3.0.5
checking for references to /build in /nix/store/pp12na2xyfm7p9nallmy7hyz0sx68yhs-gtkspellmm-3.0.5...
/nix/store/pp12na2xyfm7p9nallmy7hyz0sx68yhs-gtkspellmm-3.0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gtkspellmm

Partial log (click to expand)

make[1]: Leaving directory '/build/gtkspellmm-3.0.5'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fr50xna8jv7h4xgzi5708v1xrah4w4gl-gtkspellmm-3.0.5
shrinking /nix/store/fr50xna8jv7h4xgzi5708v1xrah4w4gl-gtkspellmm-3.0.5/lib/libgtkspellmm-3.0.so.0.2.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fr50xna8jv7h4xgzi5708v1xrah4w4gl-gtkspellmm-3.0.5/lib
patching script interpreter paths in /nix/store/fr50xna8jv7h4xgzi5708v1xrah4w4gl-gtkspellmm-3.0.5
checking for references to /build in /nix/store/fr50xna8jv7h4xgzi5708v1xrah4w4gl-gtkspellmm-3.0.5...
/nix/store/fr50xna8jv7h4xgzi5708v1xrah4w4gl-gtkspellmm-3.0.5

@teto
Copy link
Member Author

teto commented Sep 17, 2018

Indeed thanks for spotting

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018 •
edited

Did the file warning go away? It usually does not.

@teto
gtkspellmm: 3.0.4 -> 3.0.5
7893651 
Archive extension changed from tar.gz to tar.xz so be careful !
@teto
Copy link
Member Author

teto commented Sep 17, 2018

I hadn't checked because I remembered a package where adding file fixed it but in retrospect I might have patched the makefile as well. ofborg showed the message was still there so I reverted the "file" addition. Should be good now.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gtkspellmm

Partial log (click to expand)

make[1]: Leaving directory '/build/gtkspellmm-3.0.5'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/spz3llnzrjsb3v7miy6vfpr4f7kl02gj-gtkspellmm-3.0.5
shrinking /nix/store/spz3llnzrjsb3v7miy6vfpr4f7kl02gj-gtkspellmm-3.0.5/lib/libgtkspellmm-3.0.so.0.2.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/spz3llnzrjsb3v7miy6vfpr4f7kl02gj-gtkspellmm-3.0.5/lib
patching script interpreter paths in /nix/store/spz3llnzrjsb3v7miy6vfpr4f7kl02gj-gtkspellmm-3.0.5
checking for references to /build in /nix/store/spz3llnzrjsb3v7miy6vfpr4f7kl02gj-gtkspellmm-3.0.5...
/nix/store/spz3llnzrjsb3v7miy6vfpr4f7kl02gj-gtkspellmm-3.0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gtkspellmm

Partial log (click to expand)

make[1]: Leaving directory '/build/gtkspellmm-3.0.5'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hi5ybx1yij3f32m4a1gysri5sbh515zg-gtkspellmm-3.0.5
shrinking /nix/store/hi5ybx1yij3f32m4a1gysri5sbh515zg-gtkspellmm-3.0.5/lib/libgtkspellmm-3.0.so.0.2.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hi5ybx1yij3f32m4a1gysri5sbh515zg-gtkspellmm-3.0.5/lib
patching script interpreter paths in /nix/store/hi5ybx1yij3f32m4a1gysri5sbh515zg-gtkspellmm-3.0.5
checking for references to /build in /nix/store/hi5ybx1yij3f32m4a1gysri5sbh515zg-gtkspellmm-3.0.5...
/nix/store/hi5ybx1yij3f32m4a1gysri5sbh515zg-gtkspellmm-3.0.5

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018

Hmm, nothing uses this and gtkspell is dead, I would just drop this. But I guess we can keep it for a bit until the program you want to package is ported to gspell.

@jtojnar jtojnar merged commit 51a6a2b into NixOS:master Sep 17, 2018
@teto teto deleted the gtkmyspellmm branch May 13, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @jtojnar @GrahamcOfBorg