Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elementary-xfce-icon-theme: 0.12 -> 0.13 #46809

Merged
merged 2 commits into from Sep 18, 2018
Merged

elementary-xfce-icon-theme: 0.12 -> 0.13 #46809

merged 2 commits into from Sep 18, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 17, 2018

Motivation for this change

Update to version 0.13

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)

Attempted: elementary-xfce-icon-theme

Partial log (click to expand)

                                 Dload  Upload   Total   Spent    Left  Speed
copying path '/nix/store/xlj033id9dw5g8ifyskvhh52bwz2s449-librsvg-2.42.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/nfb968h86nsrb8sc956wrbbb2zfqk587-pango-1.42.1-dev' from 'https://cache.nixos.org'...
100   137    0   137    0     0    257      0 --:--:-- --:--:-- --:--:--   256
copying path '/nix/store/iqhfysn7yldnpii012ni8fs788pz8fcb-gtk+3-3.22.30-dev' from 'https://cache.nixos.org'...
100 6120k    0 6120k    0     0  2956k      0 --:--:--  0:00:02 --:--:-- 5989k
unpacking source archive /private/tmp/nix-build-source.drv-0/v0.13.tar.gz
fixed-output derivation produced path '/nix/store/p0ccwzrxhyk90skqi3q23srivxsrgsv9-source' with sha256 hash '1rzdyv8c77wjmsymxkn7z2z9yj9xk3hxmfkc86xd4izxh032qjym' instead of the expected hash '01hlpw4vh4kgyghki01jp0snbn0g79mys28fb1m993mivnlzmn75'
cannot build derivation '/nix/store/n59fkw1dv316zh3df6wq2lsp2bjadv1a-elementary-xfce-icon-theme-0.13.drv': 1 dependencies couldn't be built
error: build of '/nix/store/n59fkw1dv316zh3df6wq2lsp2bjadv1a-elementary-xfce-icon-theme-0.13.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elementary-xfce-icon-theme

Partial log (click to expand)

gtk-update-icon-cache -f //nix/store/7rbhwgyk30lldnljxzylaf3bwfv1bcpr-elementary-xfce-icon-theme-0.13/share/icons/elementary-xfce-darkest
gtk-update-icon-cache: Cache file created successfully.
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7rbhwgyk30lldnljxzylaf3bwfv1bcpr-elementary-xfce-icon-theme-0.13
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7rbhwgyk30lldnljxzylaf3bwfv1bcpr-elementary-xfce-icon-theme-0.13
checking for references to /build in /nix/store/7rbhwgyk30lldnljxzylaf3bwfv1bcpr-elementary-xfce-icon-theme-0.13...
/nix/store/7rbhwgyk30lldnljxzylaf3bwfv1bcpr-elementary-xfce-icon-theme-0.13

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: elementary-xfce-icon-theme

Partial log (click to expand)

gtk-update-icon-cache -f //nix/store/mf7i20sivgz7y6krxfa0rx6444j2bgpq-elementary-xfce-icon-theme-0.13/share/icons/elementary-xfce-darkest
gtk-update-icon-cache: Cache file created successfully.
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mf7i20sivgz7y6krxfa0rx6444j2bgpq-elementary-xfce-icon-theme-0.13
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mf7i20sivgz7y6krxfa0rx6444j2bgpq-elementary-xfce-icon-theme-0.13
checking for references to /build in /nix/store/mf7i20sivgz7y6krxfa0rx6444j2bgpq-elementary-xfce-icon-theme-0.13...
/nix/store/mf7i20sivgz7y6krxfa0rx6444j2bgpq-elementary-xfce-icon-theme-0.13

@romildo
Copy link
Contributor Author

romildo commented Sep 17, 2018

The failure on darwin looks like another instance of #39308, probably due to case conflicts in file names:

$ ls -l $(find | sort --ignore-case | uniq --ignore-case --repeated --all-repeated)
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/128/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/128/terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/16/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/16/terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/22/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/22/terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/24/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/24/terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/32/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/32/terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/48/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/48/terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/64/Terminal.svg -> utilities-terminal.svg
lrwxrwxrwx 1 nixbld nixbld 22 Jan  1  1970 ./elementary-xfce/apps/64/terminal.svg -> utilities-terminal

This is currently an issue for Darwin.

Fixed by restricting to linux platforms.

@romildo
Copy link
Contributor Author

romildo commented Sep 17, 2018

cc @davidak

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elementary-xfce-icon-theme

Partial log (click to expand)

/nix/store/7rbhwgyk30lldnljxzylaf3bwfv1bcpr-elementary-xfce-icon-theme-0.13

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: elementary-xfce-icon-theme

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: elementary-xfce-icon-theme

Partial log (click to expand)

/nix/store/mf7i20sivgz7y6krxfa0rx6444j2bgpq-elementary-xfce-icon-theme-0.13

@xeji xeji merged commit 874b045 into NixOS:master Sep 18, 2018
@davidak
Copy link
Member

davidak commented Sep 18, 2018

@romildo thanks for update and clean up!

@romildo romildo deleted the upd.elementary-xfce branch September 18, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @GrahamcOfBorg @davidak @xeji