Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcanist: fix mtime impurity #46812

Merged
merged 1 commit into from Oct 21, 2018
Merged

arcanist: fix mtime impurity #46812

merged 1 commit into from Oct 21, 2018

Conversation

yorickvP
Copy link
Contributor

This package would sometimes require bison, depending on file enumeration order. Adding -a flag to cp to preserve mtimes fixes this.

Motivation for this change

Arcanist build was failing, bisecting nixpkgs turned up the first commit to cause a rebuild of it. It worked on some systems but not others. With this commit, it works on all systems again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This package would sometimes require bison, depending on file enumeration order. Adding -a flag to cp to preserve mtimes fixes this.
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the defualt unpackPhase with srcs will do this automatically.

@c0bw3b c0bw3b merged commit 1a26028 into NixOS:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants