Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv/darwin: bump bootstrap tools #46810

Merged
merged 1 commit into from Sep 18, 2018
Merged

stdenv/darwin: bump bootstrap tools #46810

merged 1 commit into from Sep 18, 2018

Conversation

copumpkin
Copy link
Member

You can verify the provenance of these yourself by checking Hydra here: https://hydra.nixos.org/build/81511173

Motivation for this change

The old ones were ancient and still used LLVM 4. We've made quite a few fairly big changes and this should also allow us to bootstrap properly on macOS 10.14 when it comes out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@copumpkin
stdenv/darwin: bump bootstrap tools
dc5c68a 
You can verify the provenance of these yourself by checking Hydra here:
https://hydra.nixos.org/build/81511173
@copumpkin copumpkin added the 6.topic: darwin Running or building packages on Darwin label Sep 17, 2018
LnL7
LnL7 approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix/Nixpkgs are comparible with 10.14 now, but I think we need this to build a full stdenv rebuild on it.

@copumpkin copumpkin merged commit f939601 into NixOS:staging Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@copumpkin @LnL7 @GrahamcOfBorg