Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all-cabal-hashes: update snapshot to Hackage at 2018-09-12T08:26:27Z #46803

Merged
merged 1 commit into from Sep 17, 2018
Merged

all-cabal-hashes: update snapshot to Hackage at 2018-09-12T08:26:27Z #46803

merged 1 commit into from Sep 17, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Sep 17, 2018 •
edited

(cherry picked from commit ee6ecb0)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

lukateras
lukateras reviewed Sep 17, 2018
View reviewed changes
pkgs/data/misc/hackage/default.nix
@@ -1,6 +1,6 @@
{ fetchurl }:

fetchurl {
url = "https://github.com/commercialhaskell/all-cabal-hashes/archive/22cb611adaf63739fc7e3956d83d450154ec766b.tar.gz";
sha256 = "0wxggabwz8qs2hmnr3k3iwy9rmvicx4a1n22l7f6krk1hym5bkpl";
url = "https://github.com/commercialhaskell/all-cabal-hashes/archive/e44c7d34b0e57883da9cc0e09b0b5de3b065fe98.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of sad that we assume this GitHub rev archive won't ever change :-)

@lukateras lukateras merged commit a001c45 into NixOS:release-18.09 Sep 17, 2018
@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the bump-all-cabal-hashes-18.09 branch September 18, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @lukateras @GrahamcOfBorg @peti