Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greybird: remove license cc-by-nc-sa-30 #46802

Merged
merged 1 commit into from Sep 18, 2018
Merged

greybird: remove license cc-by-nc-sa-30 #46802

merged 1 commit into from Sep 18, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 17, 2018

Motivation for this change

Greybird is dual-licensed as GPLv2 or later (free) and
CC-BY-SA 3.0 or later (unfree). Remove the unfree one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Sep 17, 2018

Why is this significant? It seems helpful to encode that it is dual licensed.

@tilpner
Copy link
Member

tilpner commented Sep 17, 2018 •
edited

@grahamc As explained by @romildo on IRC

"Greybird is dual-licensed as GPLv2 or later and CC-BY-SA 3.0 or later. The first is free, and the second is unfree in nixpkgs. Currently both licenses are listed in the package derivation. And nix takes that it is unfree."
"If one of the licenses in the list is unfree. nix consider that the software is unfree."

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: greybird

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/92z237kk1321mc5qzcrj3m2a3c864sha-greybird-3.22.9
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/92z237kk1321mc5qzcrj3m2a3c864sha-greybird-3.22.9
checking for references to /build in /nix/store/92z237kk1321mc5qzcrj3m2a3c864sha-greybird-3.22.9...
/nix/store/92z237kk1321mc5qzcrj3m2a3c864sha-greybird-3.22.9

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: greybird

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: greybird

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9
checking for references to /build in /nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9...
/nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9

@romildo
Copy link
Contributor Author

romildo commented Sep 17, 2018 •
edited

The PR #46787 (from today) makes evident that greybird was not being built on GrahamcOfBorg because it is considered unfree.

@romildo
Copy link
Contributor Author

romildo commented Sep 17, 2018

The nixpkgs manual makes it clear:

If the license field is in the form of a list representation, then it means that parts of the package are licensed differently.

@romildo
Copy link
Contributor Author

romildo commented Sep 17, 2018

We need a way of express that the licenses are alternatives (one or the other). What we already have using list is not alternatives (all licenses apply, there is no choice).

@xeji
Copy link
Contributor

xeji commented Sep 18, 2018

As a workaround I suggest putting it in a comment:
license = with licenses; [ gpl2Plus ]; # or alternatively: cc-by-nc-sa-30

@romildo
greybird: remove license cc-by-nc-sa-30
8ba3737 
Greybird is dual-licensed as GPLv2 or later and CC-BY-SA 3.0 or later.
The first is free, and the second is unfree in nixpkgs. Currently both
licenses are listed in the package derivation. And nix takes that it is
unfree. If one of the licenses in the list is unfree. nix consider
that the software is unfree. Remove the unfree one.
@romildo
Copy link
Contributor Author

romildo commented Sep 18, 2018

As a workaround I suggest putting it in a comment

Done.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: greybird

Partial log (click to expand)

/nix/store/92z237kk1321mc5qzcrj3m2a3c864sha-greybird-3.22.9

@xeji
Copy link
Contributor

xeji commented Sep 18, 2018

Thanks!

@xeji xeji merged commit 1944def into NixOS:master Sep 18, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: greybird

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: greybird

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9
checking for references to /build in /nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9...
/nix/store/z5c8jjik9vkzyybbfc1ihi5szxn0w674-greybird-3.22.9

@romildo romildo deleted the upd.greybird branch September 18, 2018 11:50
@davidak
Copy link
Member

davidak commented Oct 15, 2018

@romildo could you create a PR to backport this to 18.09? My rebuild fails because it's unfree.

Currently using a workaround: davidak/nixos-config@5a588bb

@romildo
Copy link
Contributor Author

romildo commented Oct 15, 2018 •
edited

@davidak I have never done a backport. Can you tell me how to do it?

@xeji
Copy link
Contributor

xeji commented Oct 15, 2018 via email

xeji pushed a commit that referenced this pull request Oct 16, 2018
@romildo @xeji
greybird: remove license cc-by-nc-sa-30 (#46802)
8fe63a0 
Greybird is dual-licensed as GPLv2 or later and CC-BY-SA 3.0 or later.
The first is free, and the second is unfree in nixpkgs. Currently both
licenses are listed in the package derivation. And nix takes that it is
unfree. If one of the licenses in the list is unfree. nix consider
that the software is unfree. Remove the unfree one.

(cherry picked from commit 1944def)
@xeji
Copy link
Contributor

xeji commented Oct 16, 2018

backported to 18.09 in 8fe63a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@romildo @grahamc @tilpner @GrahamcOfBorg @xeji @davidak