Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixxx 2.1.3: Fixed glibc locale bug #45861

Merged
merged 1 commit into from Sep 1, 2018
Merged

mixxx 2.1.3: Fixed glibc locale bug #45861

merged 1 commit into from Sep 1, 2018

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented Aug 31, 2018

Motivation for this change

This patch fixes an ugly critical bug with filename character encoding on systems with glibc 2.26 installed as default but mixxx build with glibc 2.27.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants