Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pbrt: 2017-01-12 -> 2018-08-15; cmake 3.12 compatibility #45863

Merged
merged 1 commit into from Aug 31, 2018
Merged

pbrt: 2017-01-12 -> 2018-08-15; cmake 3.12 compatibility #45863

merged 1 commit into from Aug 31, 2018

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Aug 31, 2018 •
edited

Motivation for this change

Work with new cmake from #44910. See upstream issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

@GrahamcOfBorg build pbrt

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pbrt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: pbrt

Partial log (click to expand)

Cannot nix-instantiate `pbrt' because:
GC Warning: Failed to expand heap by 10737418240 bytes
Can't start up: not enough memory

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pbrt

Partial log (click to expand)

shrinking /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/bin/cyhair2pbrt
shrinking /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/bin/obj2pbrt
shrinking /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/bin/imgtool
shrinking /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/bin/bsdftest
shrinking /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/bin/pbrt
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/lib  /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15/bin
patching script interpreter paths in /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15
checking for references to /build in /nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15...
/nix/store/bi0pch0may08sdwi9q0n3m1qyqwa0bic-pbrt-v3-2018-08-15

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

This hit the broken x86_64-linux builder again ☹️ I am building it locally before merging.

@xeji xeji merged commit 78d842e into NixOS:staging Aug 31, 2018
@thefloweringash thefloweringash deleted the prbt-cmake-3.12 branch September 24, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @xeji @GrahamcOfBorg