Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podofo: patch for compatibility with cmake 3.12 #45857

Merged
merged 1 commit into from Aug 31, 2018
Merged

podofo: patch for compatibility with cmake 3.12 #45857

merged 1 commit into from Aug 31, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Broken by update to CMake in #44910. See upstream ticket for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

@GrahamcOfBorg build podofo

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: podofo

Partial log (click to expand)

shrinking /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/bin/podofocountpages
shrinking /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/bin/podofocolor
shrinking /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/bin/podofobox
shrinking /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/lib/libpodofo.so.0.9.6
gzipping man pages under /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/lib  /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6/bin
patching script interpreter paths in /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6
checking for references to /build in /nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6...
/nix/store/s824bn17jvpgm8ggnfm71an6zwmchqw0-podofo-0.9.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: podofo

Partial log (click to expand)

shrinking /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/bin/podofoxmp
shrinking /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/bin/podofoimgextract
shrinking /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/bin/podofosign
shrinking /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/bin/podofoimg2pdf
shrinking /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/bin/podofoencrypt
gzipping man pages under /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/lib  /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6/bin
patching script interpreter paths in /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6
checking for references to /build in /nix/store/2qcdzq5halgznp5ia8zlyfg4nmq29l69-podofo-0.9.6...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: podofo

Partial log (click to expand)

-- Installing: /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/share/man/man1/podofopdfinfo.1
-- Installing: /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/share/man/man1/podofotxt2pdf.1
-- Installing: /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/share/man/man1/podofotxtextract.1
-- Installing: /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/share/man/man1/podofouncompress.1
-- Installing: /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/share/man/man1/podofoxmp.1
post-installation fixup
gzipping man pages under /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/share/man/
strip is /nix/store/v70c180dagihxqgs2na1iw99ly64syia-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/lib  /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6/bin
patching script interpreter paths in /nix/store/94zqr62pxfzlcg3m6i0j2hw9jgdqn95b-podofo-0.9.6

@xeji xeji merged commit 51680c6 into NixOS:staging Aug 31, 2018
@xeji
Copy link
Contributor

xeji commented Aug 31, 2018

Thank you!

@thefloweringash thefloweringash deleted the podofo-cmake-3.12 branch September 24, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @xeji @GrahamcOfBorg