fbreader: 0.99.4 -> 0.99.6, switch to fetchFromGitHub, add more build options #45840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxij
force-pushed
the
pkgs/fbreader-update
branch
from
be9f7ca
to
c9af2d8
Compare
… options This, apparently, is not an official release (it's tagged, but the tarball is not available on the official site), but this repo is the official repo mentioned on the official site. This fixes a bunch of very annoying bugs present in 0.99.4, e.g. ``` $ FBReader filename ``` does not crash anymore. Yay!
oxij
force-pushed
the
pkgs/fbreader-update
branch
from
c9af2d8
to
6f57a53
Compare
|
Success on x86_64-linux (full log) Attempted: fbreader Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: fbreader Partial log (click to expand)
|
|
a big leap from 2011 -> 2016 😄 |
|
@xeji, fbreader won't build on more recent curl (due to #49514) :( geometer/FBReader#310 |
|
It does now; see 1970a4c. |
|
Thanks a lot @vcunat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, apparently, is not an official release (it's tagged, but the tarball is not available on the official site), but this repo is the official repo mentioned on the official site.
This fixes a bunch of very annoying bugs present 0.99.4, e.g.
does not crash anymore. Yay!
Motivation for this change
I hate that crash.
Things done