Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/transmission: fix AppArmor profile to include keyutils #45875

Merged
merged 1 commit into from Sep 1, 2018
Merged

nixos/transmission: fix AppArmor profile to include keyutils #45875

merged 1 commit into from Sep 1, 2018

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Aug 31, 2018

Motivation for this change

Otherwise the transmission service fails to start in NixOS 18.03 when AppArmor is enabled (at least, under my configuration).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 58c29e9 into NixOS:master Sep 1, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 1, 2018 •
edited

So this needs also a backport? I am not a fan of maintaining this apparmor profile because it is likely to break whenever downstream dependency changes. I would actually suggest to remove it or at least whitelist the nix store

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

If it's about all libraries used, that's possible to extract e.g. from ldd $out/bin/.transmission-daemon-wrapped, right?

@wizeman wizeman deleted the u/fix-transmission-mod2 branch January 24, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wizeman @Mic92 @vcunat @GrahamcOfBorg