Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: Add python3 to runtime for steam play / proton #45855

Merged
merged 1 commit into from Sep 1, 2018
Merged

steam: Add python3 to runtime for steam play / proton #45855

merged 1 commit into from Sep 1, 2018

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Aug 31, 2018

Motivation for this change

Proton stable added python3 as a hard dependency (can't find any official statements but games crashed with a file not found notice and it's mentioned on multiple places in the official issue tracker.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tgharib
Copy link
Contributor

tgharib commented Aug 31, 2018

To add, Steam Play 3.7-3 depends on python2 and still works. Steam Play 3.7-5 (intentionally) depends on python3 and therefore doesn't work.

@srhb
Copy link
Contributor

srhb commented Sep 1, 2018

Can you clarify whether this has any impact on users that don't participate in the Steam Play beta?

@pstn
Copy link
Contributor Author

pstn commented Sep 1, 2018 via email

@srhb
Copy link
Contributor

srhb commented Sep 1, 2018

@pstn Thanks!

@srhb srhb merged commit b57350e into NixOS:master Sep 1, 2018
@dywedir dywedir mentioned this pull request Sep 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pstn @tgharib @srhb @GrahamcOfBorg