Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dependency-injector: init at 3.13.1 #45871

Merged
merged 1 commit into from Sep 1, 2018
Merged

pythonPackages.dependency-injector: init at 3.13.1 #45871

merged 1 commit into from Sep 1, 2018

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Adds dependency_injector python package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Gerschtli Gerschtli requested a review from FRidh as a code owner August 31, 2018 15:01
dotlambda
dotlambda requested changes Aug 31, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -244,6 +244,8 @@ in {

dendropy = callPackage ../development/python-modules/dendropy { };

dependency_injector = callPackage ../development/python-modules/dependency_injector { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-guidelines

pkgs/development/python-modules/dependency_injector/default.nix Outdated
homepage = https://github.com/ets-labs/python-dependency-injector;
license = licenses.mit;
maintainers = with maintainers; [ gerschtli ];
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platforms is set automatically

pkgs/development/python-modules/dependency_injector/default.nix Outdated
{ stdenv, buildPythonPackage, fetchPypi, six }:

buildPythonPackage rec {
pname = "dependency_injector";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the same as below.

@Gerschtli Gerschtli changed the title pythonPackages.dependency_injector: init at 3.13.1 pythonPackages.dependency-injector: init at 3.13.1 Aug 31, 2018
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.dependency-injector python3.pkgs.dependency-injector

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.dependency-injector, python3.pkgs.dependency-injector

Partial log (click to expand)

running build_ext
copying build/lib.macosx-10.6-x86_64-3.6/dependency_injector/containers.cpython-36m-darwin.so -> src/dependency_injector
copying build/lib.macosx-10.6-x86_64-3.6/dependency_injector/providers.cpython-36m-darwin.so -> src/dependency_injector

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/7xzihvdw9y5r0y738v7rzyypfl26h76i-python2.7-dependency-injector-3.13.1
/nix/store/6xix3c9ajx387kdl37mjqi8x157y8vbk-python3.6-dependency-injector-3.13.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.dependency-injector, python3.pkgs.dependency-injector

Partial log (click to expand)

running build_ext
copying build/lib.linux-x86_64-3.6/dependency_injector/containers.cpython-36m-x86_64-linux-gnu.so -> src/dependency_injector
copying build/lib.linux-x86_64-3.6/dependency_injector/providers.cpython-36m-x86_64-linux-gnu.so -> src/dependency_injector

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/wxzp3679gl3p5qqlrqfky9n39fwn1a2l-python2.7-dependency-injector-3.13.1
/nix/store/y6bl1pl38gy4bx65g4q4c81sb2kzfm9n-python3.6-dependency-injector-3.13.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.dependency-injector, python3.pkgs.dependency-injector

Partial log (click to expand)

running build_ext
copying build/lib.linux-aarch64-3.6/dependency_injector/containers.cpython-36m-aarch64-linux-gnu.so -> src/dependency_injector
copying build/lib.linux-aarch64-3.6/dependency_injector/providers.cpython-36m-aarch64-linux-gnu.so -> src/dependency_injector

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/00aspi2kl4k5468yanlgf8can6g96ckl-python2.7-dependency-injector-3.13.1
/nix/store/r7105s9gsimn903qw3xdcbb686blbfx9-python3.6-dependency-injector-3.13.1

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase. If there are no tests, please set doCheck = false and add a comment with the reason.

@Gerschtli
Copy link
Contributor Author

It seems that the tests directory doesn't exist when running the checkPhase.. Do you know why the directory is removed?

@dotlambda
Copy link
Member

Because it's not uploaded to PyPI. You can open an upstream PR to include it in MANIFEST.in.

@Gerschtli Gerschtli mentioned this pull request Sep 1, 2018
Merged
@dotlambda dotlambda merged commit e6a3ad7 into NixOS:master Sep 1, 2018
@Gerschtli Gerschtli deleted the add/dependency_injector branch September 1, 2018 23:15
@Gerschtli Gerschtli mentioned this pull request Sep 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @dotlambda @GrahamcOfBorg