docs: Add some examples to fetchGit #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-at-target
force-pushed
the
fetch-git-examples
branch
from
417c68e
to
2df21b7
Compare
edolstra
reviewed
Aug 31, 2018
doc/manual/expressions/builtins.xml
Outdated
| clone</command>. <function>builtins.fetchGit</function> uses | ||
| a <literal>/</literal> instead of a <literal>:</literal> | ||
| between <literal>github.com</literal> and | ||
| <literal>my-secret</literal>.</para></note> |
There was a problem hiding this comment.
Why is that? I'm not aware that we rewrite Git URLs anywhere.
There was a problem hiding this comment.
Maybe the explanation is not totally correct, but:
detected as a directory:
nix-repl> builtins.fetchGit { url = "git@github.com:grahamc/nixos-config.git"; ref = "master"; }
fetching Git repository '/home/grahamc/git@github.com:grahamc/nixos-config.git'fatal: '/home/grahamc/git@github.com:grahamc/nixos-config.git' does not appear to be a git repository
fatal: Could not read from remote repository.
confused hostname:
nix-repl> builtins.fetchGit { url = "ssh://git@github.com:grahamc/nixos-config.git"; ref = "master"; }
fetching Git repository 'ssh://git@github.com:grahamc/nixos-config.git'ssh: Could not resolve hostname github.com:grahamc: Name or service not known
fatal: Could not read from remote repository.
just right:
nix-repl> builtins.fetchGit { url = "ssh://git@github.com/grahamc/nixos-config.git"; ref = "master"; }
{ outPath = "/nix/store/bf5xjh16pcgxk2lj4frmby26740q10wg-source"; rev = "0524294c41343b7c400ddc1d7442dc6bde308f95"; revCount = 66; shortRev = "0524294"; }
There was a problem hiding this comment.
The first one is a bug which I just fixed (475a0a5). The second one is not valid Git syntax I think.
There was a problem hiding this comment.
I think you are confusing ssh://git@github.com/NixOS/nix.git with git@github.com:NixOS/nix.git, the second format isn't supported in nix since that's not a uri.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug - #2385 as part of writing this, but it shouldn't block these docs.
Ideally these would be backported.
Rendered: