Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document multi-user installation, and add release notes about it not being the default on 2.1 #2388

Merged
merged 5 commits into from Sep 1, 2018

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Aug 31, 2018

Rendered docs:

image

Rendered release notes:

image

Ideally would be backported.

your system, even if it is unsupported:

<screen>
curl https://nixos.org/nix/install | sh -s -- --daemon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this give

No TTY, assuming you would say yes :)

regarding the y/n questions in the multi-user installer? That seems like a bad thing to recommend by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by your recommendation on IRC, thank you!

</para>

<para>
I you would like to explicitly opt in or out of the multi-user Nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!


# If you are on macOS, you will need to run:
sudo launchctl unload /Library/LaunchDaemons/org.nixos.nix-daemon.plist
sudo launchctl unload /Library/LaunchDaemons/org.nixos.nix-daemon.plist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just once should be enough 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

installer:

<screen>
curl https://nixos.org/nix/install | sh -s -- --no-daemon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does passing flags to bash <(command) not work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@grahamc
Copy link
Member Author

grahamc commented Aug 31, 2018

Rebased and squashed commits.

sudo rm /Library/LaunchDaemons/org.nixos.nix-daemon.plist
</screen>

There may also be references to Nix in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember, are these steps skipped during install if references to /nix are found in these files? Or does it fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails.

@grahamc grahamc force-pushed the graham/document-multi-user branch 2 times, most recently from 43d277a to 992e567 Compare September 1, 2018 12:53
@grahamc grahamc changed the title Document multi-user installation, and add release notes about it being the default on 2.1 WIP Document multi-user installation, and add release notes about it being the default on 2.1 Sep 1, 2018
@grahamc grahamc changed the title WIP Document multi-user installation, and add release notes about it being the default on 2.1 WIP Document multi-user installation, and add release notes about it not being the default on 2.1 Sep 1, 2018
@grahamc
Copy link
Member Author

grahamc commented Sep 1, 2018

Updated rendering:

image

@grahamc
Copy link
Member Author

grahamc commented Sep 1, 2018

Running an install test suite.

@grahamc
Copy link
Member Author

grahamc commented Sep 1, 2018

Install matrix says things are good (full report attached):

note macos failed because I only built a tarball for linux. The changed part of the PR worked fine:

macos-sierra-install Note: a multi-user installation is possible. See https://nixos.org/nix/manual/#sect-multi-user-installation

report-single-user-default.html.gz
macos-sierra-install performing a single-user installation of Nix...

image

@grahamc grahamc changed the title WIP Document multi-user installation, and add release notes about it not being the default on 2.1 Document multi-user installation, and add release notes about it not being the default on 2.1 Sep 1, 2018
Use sh <(...) syntax for installation to preserve stdin and prompting

also update installation docs to account for changes in multi-user selection
…t selected for Linux with systemd, and the bug about selinux
<command>sudo -i sh -c 'nix-channel --update &amp;&amp; nix-env -iA
nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo
launchctl start org.nixos.nix-daemon</command>.
</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the release notes are not the best place for platform-specific upgrade instructions, which are presumably the same for every release. Might be better to refer to some "Upgrading Nix" section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@tomberek
Copy link
Contributor

tomberek commented Sep 1, 2018

Recommend adding a link to 4.4 to where a user can find the latest Nix binary tarball.

@grahamc
Copy link
Member Author

grahamc commented Sep 1, 2018

What is the title of 4.4 you'd like a link to?

@edolstra edolstra merged commit 1f49926 into NixOS:master Sep 1, 2018
@grahamc grahamc deleted the graham/document-multi-user branch September 1, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants