Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-studio: Add desktop item #45853

Merged
merged 1 commit into from Sep 2, 2018
Merged

android-studio: Add desktop item #45853

merged 1 commit into from Sep 2, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Aug 31, 2018 •
edited

Motivation for this change

Fixes: #43688

CC: @primeos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@primeos primeos self-assigned this Sep 1, 2018
primeos
primeos requested changes Sep 1, 2018
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)
There are just a few minor improvements left that should be useful.

pkgs/applications/editors/android-studio/common.nix
name = drvName;
exec = pname;
icon = drvName;
desktopName = "Android Studio";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change that to desktopName = "Android Studio (${channel} channel)";?
I think that would be pretty useful when a user installs releases from multiple channels.

pkgs/applications/editors/android-studio/common.nix
desktopName = "Android Studio";
comment = "The official Android IDE";
categories = "Development;IDE;";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting startupNotify = true; and extraEntries="StartupWMClass=jetbrains-studio"; might be helpful as well.

@primeos primeos merged commit 044c16a into NixOS:master Sep 2, 2018
@primeos
Copy link
Member

primeos commented Sep 2, 2018

Thanks :)
(I've merged it since the branch-off for 18.09 is soon and I'll push the changes later.)

@bkchr
Copy link
Contributor Author

bkchr commented Sep 2, 2018

Ahh okay. I would have done that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos requested changes

Assignees

@primeos primeos

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @primeos @GrahamcOfBorg