Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice: add zh-CN language support #45867

Merged
merged 2 commits into from Sep 1, 2018
Merged

libreoffice: add zh-CN language support #45867

merged 2 commits into from Sep 1, 2018

Conversation

bobby285271
Copy link
Member

Motivation for this change

Add zh-CN language support for Libreoffice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

You didn't test it works well, right?

@bobby285271
Copy link
Member Author

I was ashamed to admit that I didn' t test that...😂 But I really need it...

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

No need to be ashamed. I assume you don't have enough resources for the build.

I've wanted to add Czech for some time, so let me test it with both. (I don't know Chinese at all, but I'll see if it runs and shows Chinese-like chars.)

vcunat
vcunat approved these changes Sep 1, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default version looks good.

@vcunat vcunat merged commit 5a8f1c1 into NixOS:master Sep 1, 2018
vcunat added a commit that referenced this pull request Sep 1, 2018
@vcunat
Merge #45867: libreoffice*: add zh-CN and Czech langs.
9a56eee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobby285271 @vcunat @GrahamcOfBorg @Janik-Haag