Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Alertmanager: Allow the definition of extra options on commandline #46068

Merged
merged 1 commit into from Oct 6, 2018
Merged

Prometheus Alertmanager: Allow the definition of extra options on commandline #46068

merged 1 commit into from Oct 6, 2018

Conversation

azazel75
Copy link
Contributor

@azazel75 azazel75 commented Sep 4, 2018

I stumbled upon an issue with the Alertmanager that required
an additional comand line option. See https://groups.google.com/forum/#!msg/prometheus-users/-5wd-P13xCI/lGLBHHgnBgAJ

Motivation for this change

Improve Prometheus' Alertmanager configurability

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@azazel75
Allow the definition of extra options on commandline
69e4e49 
I stumbled upon an issue with the Alertmanager that required
an additional comand line option. See https://groups.google.com/forum/#!msg/prometheus-users/-5wd-P13xCI/lGLBHHgnBgAJ
@azazel75
Copy link
Contributor Author

azazel75 commented Sep 6, 2018

cc @fpletz

@eqyiel
Copy link
Contributor

eqyiel commented Sep 13, 2018

@azazel75 see also #45302

@eqyiel
Copy link
Contributor

eqyiel commented Sep 13, 2018

@azazel75 I think your solution is more flexible though.

@matthewbauer matthewbauer merged commit 907afd1 into NixOS:master Oct 6, 2018
@eqyiel eqyiel mentioned this pull request Oct 7, 2018
Closed
9 tasks
@tomfitzhenry tomfitzhenry mentioned this pull request Jan 13, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@azazel75 @eqyiel @matthewbauer @GrahamcOfBorg @Janik-Haag