Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/novacomd: prevent non-deterministic failure #46063

Merged
merged 1 commit into from Sep 4, 2018
Merged

nixos/tests/novacomd: prevent non-deterministic failure #46063

merged 1 commit into from Sep 4, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 4, 2018

Motivation for this change

A sporadic test failure occured on Hydra when a request was sent to the daemon after the systemd unit was started, but before the daemon was actually listening. Fix by checking for open port first.

cc ZHF #45960

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

cc @dtzWill

@xeji
nixos/tests/novacomd: prevent non-deterministic failure
62086c6 
A sporadic failure occured on Hydra because a request was sent
to the daemon after the systemd unit was started, but before the
daemon was actually listening. Fix by checking for open port first.
@xeji
Copy link
Contributor Author

xeji commented Sep 4, 2018

@GrahamcOfBorg test novacomd

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.novacomd

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.novacomd

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 8.26s
cleaning up
killing machine (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/02a62jd089m7kj8nywfazhx84i8qs210-vm-test-run-novacomd

@dtzWill
Copy link
Member

dtzWill commented Sep 4, 2018

LGTM and looks like it gets the nod of approval from borg!

@dtzWill dtzWill merged commit 8dc63ce into NixOS:master Sep 4, 2018
@xeji xeji deleted the p/novacomd-test branch September 4, 2018 21:17
@xeji
Copy link
Contributor Author

xeji commented Sep 4, 2018

backported in 1ee95ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @dtzWill