Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.24 -> 1.8.25 #46057

Merged
merged 1 commit into from Sep 4, 2018
Merged

sudo: 1.8.24 -> 1.8.25 #46057

merged 1 commit into from Sep 4, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2018

https://www.sudo.ws/stable.html

(may need to scroll to the 1.8.25 notes
afternewer versions are released)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
sudo: 1.8.24 -> 1.8.25
4713602 
https://www.sudo.ws/stable.html

(may need to scroll to the 1.8.25 notes
afternewer versions are released)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sudo

Partial log (click to expand)

shrinking /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/bin/sudo
shrinking /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/bin/sudoreplay
shrinking /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/sbin/visudo
gzipping man pages under /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/libexec  /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/bin  /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/sbin
patching script interpreter paths in /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25
checking for references to /build in /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25...
moving /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/sbin/* to /nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25/bin
/nix/store/xsa64c7wg9srwdxb98lqypbsnb4qnrq7-sudo-1.8.25

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sudo

Partial log (click to expand)

shrinking /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/libexec/sudo/sudoers.so
shrinking /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/libexec/sudo/group_file.so
shrinking /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/libexec/sudo/libsudo_util.so.0.0.0
gzipping man pages under /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/libexec  /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/bin  /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/sbin
patching script interpreter paths in /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25
checking for references to /build in /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25...
moving /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/sbin/* to /nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25/bin
/nix/store/91m7xwinh9xypxld43yz1aihikv949af-sudo-1.8.25

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sudo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

xeji
xeji approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changelog looks safe enough

@xeji xeji merged commit d93aa1c into NixOS:staging Sep 4, 2018
xeji added a commit that referenced this pull request Sep 19, 2018
@xeji
Revert "sudo: 1.8.24 -> 1.8.25 (#46057)"
5a9c916 
This reverts commit d93aa1c.

Moved to master, no mass rebuild.
xeji pushed a commit that referenced this pull request Sep 19, 2018
@dtzWill @xeji
sudo: 1.8.24 -> 1.8.25 (#46057)
b026786 
https://www.sudo.ws/stable.html

(may need to scroll to the 1.8.25 notes
afternewer versions are released)

(cherry picked from commit d93aa1c)
@xeji xeji mentioned this pull request Sep 19, 2018
Closed
9 tasks
@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

No mass rebuild.

  • reverted on staging in 5a9c916
  • applied to master in b026786 so we can do the next bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @xeji