Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mxnet: fix build #46053

Merged
merged 3 commits into from Sep 5, 2018
Merged

pythonPackages.mxnet: fix build #46053

merged 3 commits into from Sep 5, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 4, 2018 •
edited

Motivation for this change

The mxnet Python package did not build after the last mxnet changes. I found some more library issues with mxnet. Moreover the version of the Python module dependencies had to be relaxed a bit.

I have bundled together the necessary changes in this pull request as multiple commits.

I tested the mxnet Python module by using it to fetch the MNIST data set and training a feed forward neural network, both of which worked on my machine.

ZHF #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
mxnet: fix library dependencies.
590ce7d 
- mxnet now builds the open source MKL DNN library. However, this
  was not included with the build.
- mxnet builds its own OpenMP library, even when OpenMP is provided
  by the system. This leads to problems, so remove the included
  OpenMP implementation:

  apache/mxnet#12160
@danieldk
python[23]Packages.graphviz: 0.5.2 -> 0.9
19ac917
@danieldk
python[23]Packages.mxnet: fix build
e57e92b 
Relax graphviz, numpy, requests dependency version bounds.
@danieldk danieldk requested a review from FRidh as a code owner September 4, 2018 18:39
@Mic92
Copy link
Member

Mic92 commented Sep 4, 2018

@GrahamcOfBorg build pythonPackages.mxnet

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.mxnet

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pythonPackages.mxnet

Partial log (click to expand)

../configure: line 484: can't create lib/Makefile: nonexistent directory
../configure: line 485: can't create lib/Makefile: nonexistent directory
../configure: line 541: can't create lib/Makefile: nonexistent directory
DONE configure
/nix/store/pjq5v1xgljr4ygb1h1xfybdjydczcqiw-stdenv-linux/setup: line 100: include/atlas_cacheedge.h: No such file or directory
builder for '/nix/store/cikyqczmwfpn9jj8bnihwgssf2mnp4hv-atlas-3.10.3.drv' failed with exit code 1
cannot build derivation '/nix/store/yxh1q331jvpgkm4r6q7rz0m9ybjwc40b-liblapack-3.8.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cfpdw4cvimmf825qmnm4bh8ww52gb9pr-mxnet-1.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/70v2gvj706ang9izcncw2lk2q3gw9942-python2.7-mxnet-1.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/70v2gvj706ang9izcncw2lk2q3gw9942-python2.7-mxnet-1.2.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.mxnet

Partial log (click to expand)

writing dependency_links to mxnet.egg-info/dependency_links.txt
reading manifest file 'mxnet.egg-info/SOURCES.txt'
writing manifest file 'mxnet.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/vdkhsjiflqwnxr3g6mimxqj6x3mrb59g-python2.7-mxnet-1.2.1

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

aarch64 failure is in a dependency and can be igored here.
LGTM - I'm currently running nix-review to make sure there's no fallout from the graphviz bump.

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

nix-review shows no regressions.

@xeji xeji merged commit bf2a902 into NixOS:master Sep 5, 2018
@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

backported in d23bc7f..dd6d9ae

@danieldk danieldk deleted the mxnet-fixes branch September 5, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @Mic92 @GrahamcOfBorg @xeji