zfs-unstable: 2018-08-13 -> 2018-09-02 #46055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 4, 2018
| @@ -182,8 +182,8 @@ in { | |||
| # this package should point to a version / git revision compatible with the latest kernel release | |||
| version = "2018-08-13"; | |||
There was a problem hiding this comment.
Can you update the date of commit here as well?
There was a problem hiding this comment.
oops, forgot that. should be correct now.
phryneas
force-pushed
the
zfs-c197a77
branch
from
efa1623
to
080a638
Compare
Mic92
changed the title
|
Tested via: $ nix-build tests/zfs.nix -A unstable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I encountered a kernel panic when shutting down the system using zfs-unstable in combination with encryption and a volume with
sync=disabled(which is suggested in https://nixos.wiki/wiki/NixOS_on_ZFS#Encrypted_ZFS ).The bug was reported (openzfs/zfs#7753) to zfs, they invesigated it on a NixOS VM and a fix was merged (openzfs/zfs#7795).
This PR pushes zfs-unstable to the current master. I've run the tests with
nix-build zfs.nix -A unstablein nixpkgs/nixos/tests.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)