Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh: 5.5.1 -> 5.6 #46052

Merged
merged 1 commit into from Sep 4, 2018
Merged

zsh: 5.5.1 -> 5.6 #46052

merged 1 commit into from Sep 4, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2018

Security, see:

https://github.com/zsh-users/zsh/blob/zsh-5.6/NEWS#L7

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zsh

Partial log (click to expand)

shrinking /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/lib/zsh/5.6/zsh/pcre.so
shrinking /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/lib/zsh/5.6/zsh/system.so
shrinking /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/lib/zsh/5.6/zsh/compctl.so
gzipping man pages under /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/lib  /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/bin
patching script interpreter paths in /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6
/nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6/share/zsh/5.6/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6...
/nix/store/wljq37xwg7nwxz83pp8a6irlw0swgn8w-zsh-5.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: zsh

Partial log (click to expand)

mkdir -m 755 -p -- /nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6/share/zsh/5.6/help
install: cannot stat './help/*': No such file or directory
make[1]: Leaving directory '/private/tmp/nix-build-zsh-5.6.drv-0/zsh-5.6/Doc'
post-installation fixup
gzipping man pages under /nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6/lib  /nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6/bin
patching script interpreter paths in /nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6
/nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6/share/zsh/5.6/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/fkwzhvvwiw8ajmgh9ws0b1vsw0s9pfxd-zsh-5.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zsh

Partial log (click to expand)

shrinking /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/lib/zsh/5.6/zsh/rlimits.so
shrinking /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/bin/zsh
shrinking /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/bin/zsh-5.6
gzipping man pages under /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/lib  /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/bin
patching script interpreter paths in /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6
/nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6/share/zsh/5.6/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6...
/nix/store/hq9zyzydfmsz2zrjvg3jfjrsajv1rp9z-zsh-5.6

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

Contains a CVE fix, should be backported to 18.09.

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

Looks like a shell, talks like a shell, great 😄

@xeji xeji merged commit 59f5a65 into NixOS:master Sep 4, 2018
xeji pushed a commit that referenced this pull request Sep 4, 2018
@dtzWill @xeji
zsh: 5.5.1 -> 5.6 (#46052)
6c449eb 
Security, see:

https://github.com/zsh-users/zsh/blob/zsh-5.6/NEWS#L7
(cherry picked from commit 59f5a65)

Backported because it contains a CVE fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @xeji