Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus-sharp-2_0: fix build #46060

Merged
merged 1 commit into from Sep 4, 2018
Merged

dbus-sharp-2_0: fix build #46060

merged 1 commit into from Sep 4, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 4, 2018 •
edited

This is a reported issue which is fixed either by downgrading mono or by using msbuild.
The use of msbuild would have been preferred here if it was in nixpkgs.

Motivation for this change

This build failure

Failure adding assembly dbus-sharp.dll to the cache: Strong name cannot be verified for delay-signed assembly

ZHF: #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

@GrahamcOfBorg build dbus-sharp-2_0 tomboy

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dbus-sharp-2_0, tomboy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dbus-sharp-2_0

The following builds were skipped because they don't evaluate on aarch64-linux: tomboy

Partial log (click to expand)

 /nix/store/ck0x3a6c5g3764cdsrds5h4bgy0xmfyp-coreutils-8.29/bin/mkdir -p '/nix/store/n466f3ylk7bxkx0lsxy3nvd7n0wd0s6c-dbus-sharp-0.8.1/lib/pkgconfig'
 /nix/store/ck0x3a6c5g3764cdsrds5h4bgy0xmfyp-coreutils-8.29/bin/install -c -m 644 dbus-sharp-2.0.pc '/nix/store/n466f3ylk7bxkx0lsxy3nvd7n0wd0s6c-dbus-sharp-0.8.1/lib/pkgconfig'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n466f3ylk7bxkx0lsxy3nvd7n0wd0s6c-dbus-sharp-0.8.1
patching script interpreter paths in /nix/store/n466f3ylk7bxkx0lsxy3nvd7n0wd0s6c-dbus-sharp-0.8.1
checking for references to /build in /nix/store/n466f3ylk7bxkx0lsxy3nvd7n0wd0s6c-dbus-sharp-0.8.1...
/nix/store/n466f3ylk7bxkx0lsxy3nvd7n0wd0s6c-dbus-sharp-0.8.1

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: dbus-sharp-2_0, tomboy

Partial log (click to expand)

copying path '/nix/store/waxc5m8nygzfh02cna452qxiiwqqwqd4-gnome-vfs-2.24.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/z0wsshnm2wl8y5sga8a1cn94qpd1zc43-libgnome-2.32.1' from 'https://cache.nixos.org'...
copying path '/nix/store/s5kg9rl96sqviiwmv0zqrgcmp6dn8ymx-libbonoboui-2.24.5' from 'https://cache.nixos.org'...
copying path '/nix/store/5839d1bskq78n6852ybgma1wgdhswfp5-libgnome-2.32.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/yvm7sy180q4h1b8hyj22apcvc24pf7dn-libgnomeui-2.24.5' from 'https://cache.nixos.org'...
copying path '/nix/store/bkd8bvafk1lmqvjkfinckh25qd9v6y1c-libbonoboui-2.24.5-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/63ldj7akrk69gp8zk6c1cf2vmhm76afx-libgnomeui-2.24.5-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/ry14s8ap3kwdh8gcym4zlg2sij44r92d-gnome-sharp-2.24.1' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/xiyrix7fj1f5rkg16463yrhxzyclx14q-tomboy-1.15.9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xiyrix7fj1f5rkg16463yrhxzyclx14q-tomboy-1.15.9.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

tomboy failure looks unrelated, mono-addins doesn't build.

@worldofpeace
Copy link
Contributor Author

Another for me squash in the ZHF then 😆

xeji
xeji reviewed Sep 4, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment for the next person looking at this...

pkgs/development/libraries/dbus-sharp/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor Author

Hmm mono-addins fails with this same error.
This fix will be in a few other places then.

@xeji xeji merged commit 33fa23f into NixOS:master Sep 4, 2018
@worldofpeace worldofpeace deleted the dbus-sharp/fix-build branch September 4, 2018 21:38
xeji pushed a commit that referenced this pull request Sep 4, 2018
@worldofpeace @xeji
dbus-sharp-2_0: fix build (#46060)
ac690fc 
(cherry picked from commit 33fa23f)
@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

backported: ac690fc

@worldofpeace worldofpeace mentioned this pull request Sep 8, 2018
Merged
9 tasks
jirkadanek pushed a commit to jirkadanek/nixpkgs that referenced this pull request Aug 27, 2019
@jiridanek
dbus-sharp: apply patch to sign the dll before installation
7c80891 
Patch from mono/dbus-sharp#72

This is a more permanent solution to NixOS#46060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @xeji @GrahamcOfBorg