Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostscript: 9.22 -> 9.24 (security) #46047

Merged
merged 2 commits into from Sep 4, 2018
Merged

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Sep 4, 2018

The $doc stuff needed changes, probably because of ghostscript newly
reacting to some configure flags that stdenv passes.

  • share/ghostscript/9.22/doc was an ugly location for documentation,
    and I didn't like their new share/ghostscript/9.24 either,
    so that got changed to share/doc/ghostscript/9.24
  • their process no longer installs examples, apparently,
    but I don't expect that would be any problem for us
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The $doc stuff needed changes, probably because of ghostscript newly
reacting to some configure flags that stdenv passes.
 - share/ghostscript/9.22/doc was an ugly location for documentation,
   and I didn't like their new share/ghostscript/9.24 either,
   so that got changed to share/doc/ghostscript/9.24
 - their process no longer installs examples, apparently,
   but I don't expect that would be any problem for us
@vcunat
Copy link
Member Author

vcunat commented Sep 4, 2018

Uh, don't merge yet, there's a slight closure mess here.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/rdwxxvyllxsddb28xyralkq9j89dig1v-ghostscript-9.24-man
gzipping man pages under /nix/store/rdwxxvyllxsddb28xyralkq9j89dig1v-ghostscript-9.24-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/rdwxxvyllxsddb28xyralkq9j89dig1v-ghostscript-9.24-man
checking for references to /build in /nix/store/rdwxxvyllxsddb28xyralkq9j89dig1v-ghostscript-9.24-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/jr9gfhcnq2cjslr18b92mn0x8ryzk6mr-ghostscript-9.24-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jr9gfhcnq2cjslr18b92mn0x8ryzk6mr-ghostscript-9.24-doc
checking for references to /build in /nix/store/jr9gfhcnq2cjslr18b92mn0x8ryzk6mr-ghostscript-9.24-doc...
/nix/store/mf7hqdyv7vx27rzb9q60p8gbbiid647g-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/msdz9nky276bpd2806nxg0p9g3l401jv-ghostscript-9.24/bin/ps2pdfwr: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/msdz9nky276bpd2806nxg0p9g3l401jv-ghostscript-9.24/bin/ps2ps: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/msdz9nky276bpd2806nxg0p9g3l401jv-ghostscript-9.24/bin/ps2ps2: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/msdz9nky276bpd2806nxg0p9g3l401jv-ghostscript-9.24/bin/unix-lpr.sh: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
gzipping man pages under /nix/store/zsm86hzpab3lin7ygivqi8vvja25sxdn-ghostscript-9.24-man/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/zsm86hzpab3lin7ygivqi8vvja25sxdn-ghostscript-9.24-man
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/icd8i8yadfp3cz2izl1x69y4vvhfi8zr-ghostscript-9.24-doc
/nix/store/msdz9nky276bpd2806nxg0p9g3l401jv-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/78dr9xazy46mrznw9xvmp3vz9jcfwaan-ghostscript-9.24-man
gzipping man pages under /nix/store/78dr9xazy46mrznw9xvmp3vz9jcfwaan-ghostscript-9.24-man/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/78dr9xazy46mrznw9xvmp3vz9jcfwaan-ghostscript-9.24-man
checking for references to /build in /nix/store/78dr9xazy46mrznw9xvmp3vz9jcfwaan-ghostscript-9.24-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/v2kvmwh2x90mfp5qzqb1lmnh3ak9sr1j-ghostscript-9.24-doc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/v2kvmwh2x90mfp5qzqb1lmnh3ak9sr1j-ghostscript-9.24-doc
checking for references to /build in /nix/store/v2kvmwh2x90mfp5qzqb1lmnh3ak9sr1j-ghostscript-9.24-doc...
/nix/store/cnv776c252mbj5l44qglvb22323ib3y4-ghostscript-9.24

- unused lcms2 input
- reference $out -> $doc
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/kpfs5sfnan6xgpshxvw68wd7n8xwanqa-ghostscript-9.24-man
gzipping man pages under /nix/store/kpfs5sfnan6xgpshxvw68wd7n8xwanqa-ghostscript-9.24-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/kpfs5sfnan6xgpshxvw68wd7n8xwanqa-ghostscript-9.24-man
checking for references to /build in /nix/store/kpfs5sfnan6xgpshxvw68wd7n8xwanqa-ghostscript-9.24-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/v2gvb7vwbigd90apvci0ghfxaynhbhas-ghostscript-9.24-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/v2gvb7vwbigd90apvci0ghfxaynhbhas-ghostscript-9.24-doc
checking for references to /build in /nix/store/v2gvb7vwbigd90apvci0ghfxaynhbhas-ghostscript-9.24-doc...
/nix/store/s9lhh0xbybl4bpifk6c8lzgv9b18ixiq-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghostscript

Partial log (click to expand)

/nix/store/s2yf2lcjp5pqgyvywifkq75b38b03znc-ghostscript-9.24/bin/ps2pdfwr: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/s2yf2lcjp5pqgyvywifkq75b38b03znc-ghostscript-9.24/bin/ps2ps: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/s2yf2lcjp5pqgyvywifkq75b38b03znc-ghostscript-9.24/bin/ps2ps2: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/s2yf2lcjp5pqgyvywifkq75b38b03znc-ghostscript-9.24/bin/unix-lpr.sh: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
gzipping man pages under /nix/store/r2b4239pv6rc6l3jah84isjycz4drshn-ghostscript-9.24-man/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/r2b4239pv6rc6l3jah84isjycz4drshn-ghostscript-9.24-man
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/14ivks323aygpj76w78kn9l4p667svz5-ghostscript-9.24-doc
/nix/store/s2yf2lcjp5pqgyvywifkq75b38b03znc-ghostscript-9.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ghostscript

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/aq7d19pfm58j7hs9zaiz39lvbgr4vxw0-ghostscript-9.24-man
gzipping man pages under /nix/store/aq7d19pfm58j7hs9zaiz39lvbgr4vxw0-ghostscript-9.24-man/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/aq7d19pfm58j7hs9zaiz39lvbgr4vxw0-ghostscript-9.24-man
checking for references to /build in /nix/store/aq7d19pfm58j7hs9zaiz39lvbgr4vxw0-ghostscript-9.24-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/cg3kgck7q3lwx8ygwy9b16k98vmylqp3-ghostscript-9.24-doc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cg3kgck7q3lwx8ygwy9b16k98vmylqp3-ghostscript-9.24-doc
checking for references to /build in /nix/store/cg3kgck7q3lwx8ygwy9b16k98vmylqp3-ghostscript-9.24-doc...
/nix/store/7yyg03lp72jkf7b1zv4sfdz84aqahmiy-ghostscript-9.24

@jb55
Copy link
Contributor

jb55 commented Sep 4, 2018 via email

@vcunat
Copy link
Member Author

vcunat commented Sep 4, 2018

Upstream claims there are no incompatible changes

so I guess we'll chance it. I see ABI changes but perhaps those were considered internal symbols or something. EDIT: I also rebuilt several dependants successfully.

@vcunat
Copy link
Member Author

vcunat commented Sep 4, 2018

@jb55: you're not the first NixOS/ofborg#178

@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 4, 2018
@vcunat vcunat merged commit a3f6a4b into NixOS:master Sep 4, 2018
vcunat added a commit that referenced this pull request Sep 4, 2018
@vcunat vcunat deleted the p/ghostscript-9.24 branch September 4, 2018 17:43
@7c6f434c
Copy link
Member

7c6f434c commented Sep 5, 2018

@jb55 Of course, even in principle closure sizes can be reported only for things that were built

vcunat added a commit that referenced this pull request Sep 5, 2018
vcunat added a commit that referenced this pull request Sep 5, 2018
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 5, 2018
@vcunat
Copy link
Member Author

vcunat commented Sep 5, 2018

has: documentation? How did Borg determine that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants