Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox bin patch channels #47330

Merged
merged 1 commit into from Sep 25, 2018
Merged

Firefox bin patch channels #47330

merged 1 commit into from Sep 25, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 25, 2018

Motivation for this change

Avoid Firefox auto-update checks

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm
firefox-bin: fix channel patching
0fe6db8 
The patchPhase wasn't being applied at all.

This patch re-enables that and also re-thinks the setting that we want
to have. Turning off the auto-update is more accurate and doesn't lose
information like it did before.
@zimbatm zimbatm mentioned this pull request Sep 25, 2018
Closed
@garbas garbas merged commit 6060940 into NixOS:master Sep 25, 2018
@zimbatm zimbatm deleted the firefox-bin-patch-channels branch September 25, 2018 14:48
@zimbatm
Copy link
Member Author

zimbatm commented Sep 25, 2018

Also pushed to 18.09 at 3583268

@garbas garbas mentioned this pull request Oct 12, 2018
Merged
@glasserc glasserc mentioned this pull request Feb 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas Awaiting requested review from garbas

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @garbas