Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk: deprecate oraclejdk 10 #47321

Merged
merged 1 commit into from Oct 11, 2018
Merged

oraclejdk: deprecate oraclejdk 10 #47321

merged 1 commit into from Oct 11, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 25, 2018

Motivation for this change

Oracle JDK 10 is no longer supported in favor of JDK 11. Oracle JDK 11 is not free of charge, and free users are guided to use OpenJDK 11.
Should we just remove the oraclejdk10 package rather than warning existing users?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

I would say we should remove unsupported versions. There is still oraclejdk8, which is an LTS version.

@taku0 taku0 mentioned this pull request Sep 25, 2018
Merged
9 tasks
@fpletz
Copy link
Member

fpletz commented Oct 11, 2018

Let's merge this and backport to the release branches for now. We can continue the removal discussion in #47375.

@fpletz fpletz merged commit 628fa1d into NixOS:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @Mic92 @fpletz @GrahamcOfBorg