Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: disable auto updates using distribution policies. #47357

Merged
merged 1 commit into from Oct 6, 2018
Merged

firefox: disable auto updates using distribution policies. #47357

merged 1 commit into from Oct 6, 2018

Conversation

coreyoconnor
Copy link
Contributor

@coreyoconnor coreyoconnor commented Sep 25, 2018 •
edited

Resolves #33884

Motivation for this change

#33884

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary fil#33884es (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Sep 25, 2018
View reviewed changes
pkgs/applications/networking/browsers/firefox-bin/default.nix Outdated
@@ -69,6 +70,14 @@ let

systemLocale = config.i18n.defaultLocale or "en-US";

policiesJson = writeText "no-update-firefox-policy.json" ''
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use builtins.toJSON to ensure well-formedness?

@coreyoconnor
Copy link
Contributor Author

a side note: partitioning the install phase of the firefox build into a separate derivation would help iterate on this.

@coreyoconnor
Copy link
Contributor Author

nm about above. Rebuilds quick. Didn't notice that used the release from mozilla. IIRC there is a from-source derivation of firefox. Does that need a similar change?

@matthewbauer matthewbauer merged commit 8dccd8c into NixOS:master Oct 6, 2018
@jtojnar jtojnar mentioned this pull request Jan 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coreyoconnor @jtojnar @matthewbauer @GrahamcOfBorg