Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-10_x: 10.9.0 -> 10.11.0 #47352

Merged
merged 1 commit into from Sep 26, 2018
Merged

nodejs-10_x: 10.9.0 -> 10.11.0 #47352

merged 1 commit into from Sep 26, 2018

Conversation

jwoudenberg
Copy link
Member

@jwoudenberg jwoudenberg commented Sep 25, 2018 •
edited

Motivation for this change

Nodejs released a new version on the 10.x branch. This updates us to use that latest release.

We closed a previous attempt for this change (#47107) pending the upgrade of libuv. This is the same PR rebased on current master. I couldn't reopen the previous PR because of the rebase, so I created this new one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jwoudenberg jwoudenberg mentioned this pull request Sep 25, 2018
Closed
9 tasks
@lo1tuma
Copy link
Member

lo1tuma commented Sep 25, 2018

I’ve tested the build locally on darwin, everything works fine.

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

@GrahamcOfBorg build nodejs-10_x

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

cc @goibhniu @gilligan @cko

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/make_warning.js
installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/fixer.js
installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/normalize-package-data/lib/extract_description.js
installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/nopt/README.md
installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/nopt/package.json
installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/nopt/LICENSE
installing /nix/store/pjdp1vhjj1aqdkpypzwbd42w36l9wdxl-nodejs-10.11.0/lib/node_modules/npm/node_modules/nopt/CHANGELOG.md
installing /nix/sto
builder for '/nix/store/dg58hp3kzr54r8aabi3cig405c36n3mg-nodejs-10.11.0.drv' failed with exit code 2
error: build of '/nix/store/dg58hp3kzr54r8aabi3cig405c36n3mg-nodejs-10.11.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/partial-deserializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/partial-deserializer.o ../deps/v8/src/snapshot/partial-deserializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/partial-serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/partial-serializer.o ../deps/v8/src/snapshot/partial-serializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer-common.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer-common.o ../deps/v8/src/snapshot/serializer-common.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/serializer.o ../deps/v8/src/snapshot/serializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-common.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-common.o ../deps/v8/src/snapshot/snapshot-common.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-source-sink.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/snapshot-source-sink.o ../deps/v8/src/snapshot/snapshot-source-sink.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-deserializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-deserializer.o ../deps/v8/src/snapshot/startup-deserializer.cc
  clang++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj/gen -I/nix/store/vqypcqfxp86ns4x0h5yx8hx04l3rvkh5-zlib-1.2.11-dev/include -I/nix/store/rshnb8l9z88jblb7ijgp00n9v2rjb519-libuv-1.23.0/include -I/nix/store/afahs4y1av0hzs69n18xpk1zvwsfwk7y-openssl-1.1.1-dev/include -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/.deps//private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-serializer.o.d.raw   -c -o /private/tmp/nix-build-nodejs-10.11.0.drv-0/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/snapshot/startup-serializer.o ../deps/v8/src/snapshot/startup-serializer.cc
building of '/nix/store/4al1ip2cfwbyyx6y385i9qijm6h3326p-nodejs-10.11.0.drv' timed out after 1800 seconds
error: build of '/nix/store/4al1ip2cfwbyyx6y385i9qijm6h3326p-nodejs-10.11.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

In file included from ../deps/v8/src/heap/incremental-marking.h:11:0,
                 from ../deps/v8/src/heap/incremental-marking.cc:5:
../deps/v8/src/heap/mark-compact.h:464:19: note: 'result' was declared here
       HeapObject* result;
                   ^~~~~~
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.11.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.11.0/out/Release/.deps//build/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/heap/invalidated-slots.o.d.raw   -c -o /build/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/heap/invalidated-slots.o ../deps/v8/src/heap/invalidated-slots.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.11.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.11.0/out/Release/.deps//build/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/heap/item-parallel-job.o.d.raw   -c -o /build/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/heap/item-parallel-job.o ../deps/v8/src/heap/item-parallel-job.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.28"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.11.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.11.0/out/Release/.deps//build/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/heap/mark-compact.o.d.raw   -c -o /build/node-v10.11.0/out/Release/obj.target/v8_base/deps/v8/src/heap/mark-compact.o ../deps/v8/src/heap/mark-compact.cc
building of '/nix/store/mnfh783ijb6l9ydchwg8b49wnaiifa12-nodejs-10.11.0.drv' timed out after 3600 seconds
error: build of '/nix/store/mnfh783ijb6l9ydchwg8b49wnaiifa12-nodejs-10.11.0.drv' failed

@globin globin merged commit e0f4610 into NixOS:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jwoudenberg @lo1tuma @Mic92 @GrahamcOfBorg @globin