Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: support opening urls under wayland #47351

Merged
merged 1 commit into from Sep 25, 2018
Merged

tdesktop: support opening urls under wayland #47351

merged 1 commit into from Sep 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2018

Motivation for this change

In case of pure wayland environment (X server disabled) xdg is not available, so telegram unable to open urls in browser
Unable to detect a web browser to launch 'https://alexmak.net/2018/09/24/mojave-0day/'
After this PR there is no more error and url opens in browser
Created new window in existing browser session

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

@GrahamcOfBorg build telegram-desktop

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: telegram-desktop

Partial log (click to expand)

Cannot nix-instantiate `telegram-desktop' because:
error: attribute 'telegram-desktop' in selection path 'telegram-desktop' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: telegram-desktop

Partial log (click to expand)

Cannot nix-instantiate `telegram-desktop' because:
error: attribute 'telegram-desktop' in selection path 'telegram-desktop' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: telegram-desktop

Partial log (click to expand)

Cannot nix-instantiate `telegram-desktop' because:
error: attribute 'telegram-desktop' in selection path 'telegram-desktop' not found

@ghost ghost changed the title telegram-desktop: support opening urls under wayland tdesktop: support opening urls under wayland Sep 25, 2018
@ghost
Copy link
Author

ghost commented Sep 25, 2018

@Mic92 oops, sorry. Attribute name is tdesktop actually

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

@GrahamcOfBorg build tdesktop

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tdesktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tdesktop

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/grbjac6k3d4avyr4a8sla1hf3h83ma28-telegram-desktop-1.3.14
shrinking /nix/store/grbjac6k3d4avyr4a8sla1hf3h83ma28-telegram-desktop-1.3.14/bin/telegram-desktop
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/grbjac6k3d4avyr4a8sla1hf3h83ma28-telegram-desktop-1.3.14/bin
patching script interpreter paths in /nix/store/grbjac6k3d4avyr4a8sla1hf3h83ma28-telegram-desktop-1.3.14
checking for references to /build in /nix/store/grbjac6k3d4avyr4a8sla1hf3h83ma28-telegram-desktop-1.3.14...
postPatchMkspecs
postPatchMkspecs
/nix/store/grbjac6k3d4avyr4a8sla1hf3h83ma28-telegram-desktop-1.3.14

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tdesktop

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mgac6sjf9jq0m76cj5j33ys0pag8w1f0-telegram-desktop-1.3.14
shrinking /nix/store/mgac6sjf9jq0m76cj5j33ys0pag8w1f0-telegram-desktop-1.3.14/bin/telegram-desktop
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mgac6sjf9jq0m76cj5j33ys0pag8w1f0-telegram-desktop-1.3.14/bin
patching script interpreter paths in /nix/store/mgac6sjf9jq0m76cj5j33ys0pag8w1f0-telegram-desktop-1.3.14
checking for references to /build in /nix/store/mgac6sjf9jq0m76cj5j33ys0pag8w1f0-telegram-desktop-1.3.14...
postPatchMkspecs
postPatchMkspecs
/nix/store/mgac6sjf9jq0m76cj5j33ys0pag8w1f0-telegram-desktop-1.3.14

@Mic92 Mic92 merged commit f4adfea into NixOS:master Sep 25, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

backport: f221052

@ghost
Copy link
Author

ghost commented Sep 26, 2018

@Mic92 Thanks!

@ghost ghost deleted the telegram branch September 26, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg