Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleci-cli: 0.1.2307 -> 0.1.2569 #47347

Merged
merged 1 commit into from Sep 25, 2018
Merged

circleci-cli: 0.1.2307 -> 0.1.2569 #47347

merged 1 commit into from Sep 25, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Sep 25, 2018 •
edited

Motivation for this change

New version? These guys have several releases per day, because they release whenever their CI succeeds (not too strange for a CI comany, but I'm not gonna keep up with them). Any suggestions on how to handle this? Can @r-ryantm (@ryantm) handle this package already?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: circleci-cli

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vsqb1b7j8zf7l15rl7kll1r8daq42p03-circleci-cli-0.1.2569-bin
shrinking /nix/store/vsqb1b7j8zf7l15rl7kll1r8daq42p03-circleci-cli-0.1.2569-bin/bin/circleci-cli
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vsqb1b7j8zf7l15rl7kll1r8daq42p03-circleci-cli-0.1.2569-bin/bin
patching script interpreter paths in /nix/store/vsqb1b7j8zf7l15rl7kll1r8daq42p03-circleci-cli-0.1.2569-bin
checking for references to /build in /nix/store/vsqb1b7j8zf7l15rl7kll1r8daq42p03-circleci-cli-0.1.2569-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/vsqb1b7j8zf7l15rl7kll1r8daq42p03-circleci-cli-0.1.2569-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: circleci-cli

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fiy7n8zvf4xp4074cqjr8dkg4swpjynf-circleci-cli-0.1.2569-bin
shrinking /nix/store/fiy7n8zvf4xp4074cqjr8dkg4swpjynf-circleci-cli-0.1.2569-bin/bin/circleci-cli
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fiy7n8zvf4xp4074cqjr8dkg4swpjynf-circleci-cli-0.1.2569-bin/bin
patching script interpreter paths in /nix/store/fiy7n8zvf4xp4074cqjr8dkg4swpjynf-circleci-cli-0.1.2569-bin
checking for references to /build in /nix/store/fiy7n8zvf4xp4074cqjr8dkg4swpjynf-circleci-cli-0.1.2569-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/fiy7n8zvf4xp4074cqjr8dkg4swpjynf-circleci-cli-0.1.2569-bin

@xeji xeji merged commit 5a12a5b into NixOS:master Sep 25, 2018
@ryantm
Copy link
Member

ryantm commented Sep 25, 2018

@Synthetica9

Currently nixpkgs-update has any package that contains buildGoPackage blacklisted, because they usually have a separate dependency lock file that has to be updated in sync and nixpkgs-update doesn't know how to do that currently.

I don't think you need to worry about keeping up with them, just updating it every few months or whenever you need a new version is great!

@zowoq zowoq mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @GrahamcOfBorg @ryantm @xeji