New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: 1.10.1 -> 1.15.0 #47348
grpc: 1.10.1 -> 1.15.0 #47348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update pkgs/development/python-modules/grpcio/default.nix
to 1.15.0 to keep those in sync?
name = "grpc-${version}"; | ||
src = fetchurl { | ||
url = "https://github.com/grpc/grpc/archive/v${version}.tar.gz"; | ||
sha256 = "0l721r24d6wz889vz4g6i67ijz0zc0ah967i3immi90zdmjwlyjg"; | ||
sha256 = "0jv3p7i047ay6jak4i9fr9fs39w760hfl4ls0mzgih2i7i7w6g01"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you switch to fetchFromGitHub
? GitHub archives do not have a stable hash.
@@ -1,14 +1,14 @@ | |||
{ stdenv, fetchurl, cmake, zlib, c-ares, pkgconfig, openssl, protobuf, gflags }: | |||
{ stdenv, fetchurl, cmake, zlib, c-ares, pkgconfig, openssl, protobuf3_6, gflags }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep protobuf
here; override it with
grpc = callPackage … {
protobuf = protobuf3_6;
}
in all-packages.nix
.
@orivej Done. |
bc1a8d8
to
292bb74
Compare
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)