Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: move perl-bindings inside common function #47316

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

alyssais
Copy link
Member

Motivation for this change

It looks like originally not all Nix packages had perl bindings, but now that they do, it seems pretty redundant to add them seperately for each package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 25, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix

Partial log (click to expand)

copying path '/nix/store/q5da9r398qf94519wabwnrgchxi2mi5h-busybox-1.29.3' from 'https://cache.nixos.org'...
copying path '/nix/store/fabkavnyvhky88a2slh8fab97099ahdr-nix-2.1.3-man' from 'https://cache.nixos.org'...
copying path '/nix/store/x5m2da3g3x2x7l6c8gsxna1910jjzy7i-brotli-1.0.7-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/wn9jhf5wkx8xnsn5f2pb5qx7hfd2a08g-libatomic_ops-7.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/95v4dk3xbbnj3amhrblviwl9hahlz7mz-aws-sdk-cpp-1.6.20' from 'https://cache.nixos.org'...
copying path '/nix/store/j4f0vl0dvii119wh50pyrxiv2hbbrng8-curl-7.59.0' from 'https://cache.nixos.org'...
copying path '/nix/store/hlnmgwbnjfvgprbzh0a58vcqzlh7mr8b-libsodium-1.0.16' from 'https://cache.nixos.org'...
copying path '/nix/store/pyqfm4dzkgx3andxqi3y6wl6r34k6b9p-boehm-gc-7.6.8' from 'https://cache.nixos.org'...
copying path '/nix/store/6vyk8s4f90z3crghqq1xd2kpgykcgm4g-nix-2.1.3' from 'https://cache.nixos.org'...
/nix/store/6vyk8s4f90z3crghqq1xd2kpgykcgm4g-nix-2.1.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix

Partial log (click to expand)

/nix/store/55xkmqns51sw7nrgykp5vnz36w4fr3cw-nix-2.1.3

Verified

This commit was signed with the committer’s verified signature. The key has expired.
globin Robin Gloster
It looks like originally not all Nix packages had perl bindings, but now
that they do, it seems pretty redundant to add them seperately for each
package.
@Mic92 Mic92 merged commit 18a2cdf into NixOS:master Jan 26, 2019
@Ma27
Copy link
Member

Ma27 commented Feb 3, 2019

This seems to break the perl bindings in Nix 1 which I noticed while testing the Hydra bump in #55101 with Nix1.

I'll probably push a fix onto the hydra-update branch for this before updating.

@Ma27 Ma27 mentioned this pull request Feb 3, 2019
10 tasks
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Feb 8, 2019

Verified

This commit was signed with the committer’s verified signature. The key has expired.
globin Robin Gloster
Nix 1.11 builds perl-bindings by default, `nix1.perl-bindings` fails
with the following error:

```
building
no Makefile, doing nothing
installing
install flags: install
make: *** No rule to make target 'install'.  Stop.
```

This is probably due to NixOS#47316. Previously the `perl-bindings` were
referenced to `nix1` instead of the `perl-bindings` function as Nix 1.11
built those during its build process.
@alyssais alyssais deleted the nix-perl-bindings branch February 13, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants