Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq module: Update documentation #47346

Merged
merged 2 commits into from Nov 13, 2018
Merged

rabbitmq module: Update documentation #47346

merged 2 commits into from Nov 13, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Sep 25, 2018

Elaborate on the two config file formats.

Motivation for this change

The module was changed to support both formats, but the documentation was quite minimal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 26, 2018

cc @grahamc

Elaborate on the two config file formats.
nixos/modules/services/amqp/rabbitmq.nix Outdated Show resolved Hide resolved
nixos/modules/services/amqp/rabbitmq.nix Outdated Show resolved Hide resolved
@roberth roberth merged commit 9871fe3 into master Nov 13, 2018
@Mic92 Mic92 deleted the roberth-patch-1 branch November 13, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants