Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy, scipy: Fix some nativeBuildInputs #47355

Merged
merged 2 commits into from Sep 25, 2018
Merged

numpy, scipy: Fix some nativeBuildInputs #47355

merged 2 commits into from Sep 25, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 25, 2018 •
edited

Motivation for this change

checkInputs were not touched for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 mentioned this pull request Sep 25, 2018
Merged
9 tasks
@FRidh
Copy link
Member

FRidh commented Sep 25, 2018

Could you also look at scipy

@Ericson2314
Copy link
Member Author

Sure!

FRidh
FRidh reviewed Sep 25, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, something else. This will break the concept of checkInputs. We should think of a long-term solution to that.

@FRidh
Copy link
Member

FRidh commented Sep 25, 2018

I suppose those can always be added to nativeBuildInputs

@Ericson2314
Copy link
Member Author

I left pycheck in checkInputs for now and just moved gfortran. But yes, longer term checkInputs doesn't scale :/. I recall there is an issue on this.

@Ericson2314 Ericson2314 changed the base branch from master to staging September 25, 2018 18:21
@Ericson2314 Ericson2314 changed the title numpy: gfortran and pytest should be nativeBuildInputs numpy, scipy: Fix some nativeBuildInputs Sep 25, 2018
@Ericson2314 Ericson2314 merged commit 8cbf560 into NixOS:staging Sep 25, 2018
@Ericson2314 Ericson2314 deleted the numpy-fortran branch September 25, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @FRidh @GrahamcOfBorg