Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retroshare: mark as broken #47350

Merged
merged 1 commit into from Sep 28, 2018
Merged

retroshare: mark as broken #47350

merged 1 commit into from Sep 28, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Sep 25, 2018

Motivation for this change

It was broken by libupnp: 1.6.21 -> 1.8.3 (#41684).

Even after patching libupnp with mrjimenez/pupnp-backup@9220f76 to fix an include bug in libupnp, and updating retroshare to the latest release 0.6.4, it fails to compile with errors like:

error: invalid static_cast from type 'int (*)(Upnp_EventType, void*, void*) {aka int (*)(Upnp_EventType_e, void*, void*)}' to type 'Upnp_FunPtr {aka int (*)(Upnp_EventType_e, const void*, void*)}'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej
retroshare: mark as broken
61d2118 
Broken by libupnp: 1.6.21 -> 1.8.3 (NixOS#41684).
@orivej
Copy link
Contributor Author

orivej commented Sep 25, 2018

/cc maintainers @domenkozar

@xeji
Copy link
Contributor

xeji commented Sep 25, 2018

also affects 18.09 ZHF #45960, please backport

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: retroshare

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: retroshare

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: retroshare

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit eeac44c into NixOS:master Sep 28, 2018
xeji pushed a commit that referenced this pull request Sep 28, 2018
@orivej @xeji
retroshare: mark as broken (#47350)
1e1821c 
Broken by libupnp: 1.6.21 -> 1.8.3 (#41684).

(cherry picked from commit eeac44c)
@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

backported to 18.09: 1e1821c

@mehlon mehlon mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @xeji @GrahamcOfBorg