Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbsigntool: 0.5 -> 0.9.1 #47349

Merged
merged 1 commit into from Oct 6, 2018
Merged

sbsigntool: 0.5 -> 0.9.1 #47349

merged 1 commit into from Oct 6, 2018

Conversation

charles-dyfis-net
Copy link
Contributor

@charles-dyfis-net charles-dyfis-net commented Sep 25, 2018 •
edited

Motivation for this change

0.9.0 adds support for OpenSSL 1.1; 0.9.1 adds engine support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS (not supported)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (functionality not tested across all tools, but invocation checked everywhere)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@charles-dyfis-net
Copy link
Contributor Author

(Aside: The first had a git dependency added due to errors otherwise emitted during create-ccan-tree; however, those errors are actually harmless).

@matthewbauer
Copy link
Member

@GrahamcOfBorg build sbsigntool

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sbsigntool

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sbsigntool

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sbsigntool

Partial log (click to expand)

shrinking /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1/bin/sbkeysync
shrinking /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1/bin/sbattach
shrinking /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1/bin/sbvarsign
shrinking /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1/bin/sbsign
gzipping man pages under /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1/bin
patching script interpreter paths in /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1
checking for references to /build in /nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1...
/nix/store/cjhinn8hj81n1wb4jxgn4rl1gxlc66rc-sbsigntool-0.9.1

@matthewbauer matthewbauer merged commit 70faf05 into NixOS:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charles-dyfis-net @matthewbauer @GrahamcOfBorg