Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.go-x11-client: init at 0.0.4.1 #46885

Closed
wants to merge 1 commit into from
Closed

deepin.go-x11-client: init at 0.0.4.1 #46885

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 19, 2018

Motivation for this change

Add go-x11-client, a X11 protocol go language binding.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@romildo romildo changed the title go-x11-client: init at 0.0.4.1 deepin.go-x11-client: init at 0.0.4.1 Sep 19, 2018
@romildo
Copy link
Contributor Author

romildo commented Sep 19, 2018

@GrahamcOfBorg build deepin.go-x11-client

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: deepin.go-x11-client

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: deepin.go-x11-client

Partial log (click to expand)

cp *.go /nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client
cp -r ext /nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client
cp -r util /nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1
/nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client/util/tool/gen-keysymdef/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1...
/nix/store/3vfrq1k9kgp6b6pchyi87fpa8qkwchg8-go-x11-client-0.0.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: deepin.go-x11-client

Partial log (click to expand)

cp *.go /nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client
cp -r ext /nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client
cp -r util /nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1
/nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1/share/gocode/src/github.com/linuxdeepin/go-x11-client/util/tool/gen-keysymdef/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1...
/nix/store/ihw9vihz35hddpprfm5f05km3d70wczx-go-x11-client-0.0.4.1

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

This just creates a package containing the go source code for go-x11-client.
Doesn't make much sense to me. Why should we package go code that is available directly on github?

@romildo
Copy link
Contributor Author

romildo commented Sep 19, 2018

This just creates a package containing the go source code for go-x11-client.
Doesn't make much sense to me. Why should we package go code that is available directly on github?

Because it is released and it is a build dependency for other packages (dde-api, for instance; see #46833) which does not build easily using buildGoPackage.

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

So basically this is just an additional source for some packages. You could put that into a let-expression in deepin/default.nix and inherit it to any packages that need it. This achieves the same result but without exposing deepin.go-x11-client as a separate package in nixpkgs (which I would prefer to avoid).

@Mic92
Copy link
Member

Mic92 commented Nov 10, 2018

I agree, this can become a private dependency

@Mic92 Mic92 closed this Nov 10, 2018
@romildo romildo deleted the upd.deepin.go-x11-client branch March 27, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @GrahamcOfBorg @xeji @Mic92