Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.cohttp: 1.0.2 -> 1.1.1 #46906

Merged
merged 1 commit into from Sep 20, 2018
Merged

ocamlPackages.cohttp: 1.0.2 -> 1.1.1 #46906

merged 1 commit into from Sep 20, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 19, 2018

Motivation for this change

LWT 4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 19, 2018

@GrahamcOfBorg build ocamlPackages.git-unix

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ocamlPackages.git-unix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.git-unix

Partial log (click to expand)

no configure script, doing nothing
building
installing
Processing file git-unix.install as git-unix.
post-installation fixup
moving /nix/store/zjl58id3mvgzpqbcs6jdmps0sc8hqj7w-ocaml4.06.1-git-unix-1.11.5/doc to /nix/store/zjl58id3mvgzpqbcs6jdmps0sc8hqj7w-ocaml4.06.1-git-unix-1.11.5/share/doc
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/zjl58id3mvgzpqbcs6jdmps0sc8hqj7w-ocaml4.06.1-git-unix-1.11.5/lib  /nix/store/zjl58id3mvgzpqbcs6jdmps0sc8hqj7w-ocaml4.06.1-git-unix-1.11.5/bin
patching script interpreter paths in /nix/store/zjl58id3mvgzpqbcs6jdmps0sc8hqj7w-ocaml4.06.1-git-unix-1.11.5
/nix/store/zjl58id3mvgzpqbcs6jdmps0sc8hqj7w-ocaml4.06.1-git-unix-1.11.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.git-unix

Partial log (click to expand)

post-installation fixup
moving /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5/doc to /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5
shrinking /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5/lib/ocaml/4.06.1/site-lib/git-unix/git_unix.cmxs
shrinking /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5/bin/ogit
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5/lib  /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5/bin
patching script interpreter paths in /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5
checking for references to /build in /nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5...
/nix/store/a8gvy4cszc0gy7fn5zw6wqrv0kxh39bp-ocaml4.06.1-git-unix-1.11.5

@srhb
Copy link
Contributor

srhb commented Sep 20, 2018

Thanks! It's unclear to me whether this is a minor bump that ought to be backported (at least to 18.09) or a api breaking change that shouldn't be, do you know?

@srhb srhb merged commit 280ebc2 into NixOS:master Sep 20, 2018
@vbgl vbgl deleted the ocaml-cohttp-1.1.1 branch September 20, 2018 17:00
@vbgl
Copy link
Contributor Author

vbgl commented Sep 20, 2018

I would say it’s worth cherry-picking into 18.09.

srhb pushed a commit to srhb/nixpkgs that referenced this pull request Sep 25, 2018
@vbgl @srhb
ocamlPackages.cohttp: 1.0.2 -> 1.1.1
c7e76b5 
(cherry picked from commit a3c820d)
Backport of NixOS#46906
@srhb srhb mentioned this pull request Sep 25, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @srhb