Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.pandoc-crossref: refactor disable tests for 0.3.2.1 #46893

Merged
merged 1 commit into from Sep 19, 2018
Merged

haskellPackages.pandoc-crossref: refactor disable tests for 0.3.2.1 #46893

merged 1 commit into from Sep 19, 2018

Conversation

costrouc
Copy link
Member

Author acknowleges test failing (change when no longer 0.3.2.1). There is only one test that fails.

lierdakil/pandoc-crossref#199

Motivation for this change

Using pandoc-crossref for my dissertation. Overrides are a pain (not hard to do though).

Things done

haskellPackages.pandoc-crossref: refactor disable tests for 0.3.2.1

Disabled test for 0.3.2.1. I can verify that the release works as intended.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji suggested changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hackage-packages.nix is auto-generated and should not be edited, see comment at top of file.

This change should go into configuration-nix.nix, see examples using dontCheck there.

@costrouc costrouc force-pushed the costrouc/pandoc-crossref-refactor branch from a21adf1 to 13212da Compare September 19, 2018 14:59
@costrouc
Copy link
Member Author

Feel dumb for not spotting that! Thank you.

/* hackage-packages.nix is an auto-generated file -- DO NOT EDIT! */

I have made the changes and applied them in configuration-nix.nix as requested.

  # Author acknowleges test failing (change when no longer 0.3.2.1)
  # https://github.com/lierdakil/pandoc-crossref/issues/199
  pandoc-crossref = dontCheck super.pandoc-crossref;

peti
peti requested changes Sep 19, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these changes to configuration-common.nix. I don't think the test failures are specific to Nix?

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

sorry, my mistake.

@costrouc
Copy link
Member Author

@peta the single test fails due to a newer minor version of pandoc being used by nix. The author stated that he has no intention of fixing the test for the release. Is configuration-common.nix the appropriate file to modify?

Upstream tends to change LaTeX output between minor releases, sometimes significantly. Aside from covering test code in conditionals on Pandoc's version (which I won't do for obvious reasons), or removing those tests altogether (which I also don't want to do because despite being flaky, they're useful), there's nothing I can do really.

@costrouc
haskellPackages.pandoc-crossref: refactor disable tests for 0.3.2.1
e1ed5b2 
Author acknowleges test failing (change when no longer 0.3.2.1).
lierdakil/pandoc-crossref#199
@costrouc costrouc force-pushed the costrouc/pandoc-crossref-refactor branch from 13212da to e1ed5b2 Compare September 19, 2018 18:47
@costrouc
Copy link
Member Author

Changes have been made and tests are now disabled in coniguration-common.nix.

@peti peti merged commit 3c95fb1 into NixOS:master Sep 19, 2018
@rnhmjoj rnhmjoj mentioned this pull request Jan 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji requested changes

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @xeji @peti @GrahamcOfBorg