Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightdm: fix tmpfiles path #46886

Merged
merged 1 commit into from Sep 19, 2018
Merged

lightdm: fix tmpfiles path #46886

merged 1 commit into from Sep 19, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Sep 19, 2018

Motivation for this change

Fixes the tmpfiles path

[/etc/tmpfiles.d/nixos.conf:5] Line references path below legacy directory /var/run/, updating /var/run/lightdm → /run/lightdm; please update the tmpfiles.d/ drop-in file accordingly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

Related to #46734 . cc @worldofpeace. /var/run is symlinked to /run anyway, but we should get rid of the annoying warning.

@Mic92
Copy link
Member

Mic92 commented Sep 19, 2018

@GrahamcOfBorg test lightdm

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.lightdm

Partial log (click to expand)

Cannot nix-instantiate `tests.lightdm' because:
error: attribute 'lightdm' in selection path 'tests.lightdm' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.lightdm

Partial log (click to expand)

Cannot nix-instantiate `tests.lightdm' because:
error: attribute 'lightdm' in selection path 'tests.lightdm' not found

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

the lightdm test isn't part of release.nix ... but the gnome3 test uses lightdm
@GrahamcOfBorg test gnome3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.gnome3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 53.95s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/rvffy07ai4lpd080z9vkq70z2vggz4vs-vm-test-run-gnome3

@xeji xeji merged commit 1a15b10 into NixOS:master Sep 19, 2018
xeji pushed a commit that referenced this pull request Sep 19, 2018
@eadwu @xeji
lightdm: fix tmpfiles path (#46886)
d3905a3 
(cherry picked from commit 1a15b10)
@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

the error affects 18.09, backported in d3905a3

@worldofpeace
Copy link
Contributor

Just noticed this today, I think we need to do this too https://git.archlinux.org/svntogit/packages.git/tree/trunk/lightdm-default-config.patch?h=packages/lightdm#n16

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

Thanks! I'm not sure that patch can be applied as is to nixpkgs, we'll have to check these changes first.

@worldofpeace
Copy link
Contributor

I mean just the change at line 16.

@worldofpeace worldofpeace mentioned this pull request Sep 19, 2018
Merged
9 tasks
@eadwu eadwu deleted the lightdm/fix-path branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @xeji @Mic92 @GrahamcOfBorg @worldofpeace