Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/hibernate: prevent non-deterministic failure on i686 #46882

Merged
merged 1 commit into from Sep 19, 2018
Merged

nixos/tests/hibernate: prevent non-deterministic failure on i686 #46882

merged 1 commit into from Sep 19, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 19, 2018

Motivation for this change

Fix non-deterministic failures, mostly on i686.

Improve timing. With this, the failures are no longer reproducible on my machine.

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/hibernate: prevent non-deterministic failure
ec94c29 
... that occurred mostly on i686. Improve timing.
With this, the failures are no longer reproducible on my machine.
@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

@GrahamcOfBorg test hibernate

@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

cc ZHF #45960, please backport.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.hibernate

Partial log (click to expand)

syncing
probe: running command: sync
probe: exit status 0
test script finished in 49.61s
cleaning up
killing machine (pid 698)
killing probe (pid 652)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/zhab7yx7pzzzvv568g8vrqgbz8dxiscr-vm-test-run-hibernate

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.hibernate

Partial log (click to expand)

machine# [   22.043199] nc[772]: test
machine# [   22.046285] systemd-sleep[777]: System resumed.
probe: exit status 0
test script finished in 48.30s
cleaning up
killing machine (pid 674)
killing probe (pid 654)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/37g48z7caiwc1pa7snb8fnippr22wvsi-vm-test-run-hibernate

@xeji xeji merged commit beb8ca2 into NixOS:master Sep 19, 2018
xeji added a commit that referenced this pull request Sep 19, 2018
@xeji
nixos/tests/hibernate: prevent non-deterministic failure (#46882)
d5d36e5 
... that occurred mostly on i686. Improve timing.
With this, the failures are no longer reproducible on my machine.

(cherry picked from commit beb8ca2)
@xeji xeji deleted the p/hibernate-test branch September 19, 2018 14:21
@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

backported: d5d36e5

@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

Unfortunately this didn't fix the issue on Hydra. Can't tell from the logs why.

@xeji xeji mentioned this pull request Sep 20, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg