Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkManager VPN plugins are broken on master (and 18.09) #46901

Closed
wants to merge 1 commit into from
Closed

NetworkManager VPN plugins are broken on master (and 18.09) #46901

wants to merge 1 commit into from

Conversation

garbas
Copy link
Member

@garbas garbas commented Sep 19, 2018

Motivation for this change

This PR includes only a fix for OpenVPN plugin, but we can consider it a hack since I'm not that familiar with networkmanager's build system and how to set @PLUGINDIR@ correctly.

Any help / pointers from maintainers is greatly appreciated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@garbas garbas added 1.severity: blocker 0.kind: regression Something that worked before working no longer labels Sep 19, 2018
@garbas
Copy link
Member Author

garbas commented Sep 19, 2018

I marked this as a blocker since networkmanager is quite a popular package.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 19, 2018

Apparently the previously installed name files were legacy, only installed with nm-glib. The new files are substituted with NM_PLUGIN_DIR_NAME_FILE, which is set here. You need to add --enable-absolute-paths to configureFlags.

@symphorien symphorien mentioned this pull request Sep 23, 2018
Merged
9 tasks
@garbas
Copy link
Member Author

garbas commented Sep 23, 2018 •
edited

Closing since it has been done in #47212, and tnx @jtojnar for the tip. i couldn't find time to get it done

@garbas garbas closed this Sep 23, 2018
@garbas garbas deleted the networkmaneger-vpn-plugins-broken branch September 23, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 1.severity: blocker 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garbas @jtojnar @GrahamcOfBorg