Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin: 0.16.2 -> 0.16.3 #46891

Merged
merged 1 commit into from Sep 20, 2018
Merged

bitcoin: 0.16.2 -> 0.16.3 #46891

merged 1 commit into from Sep 20, 2018

Conversation

roconnor
Copy link
Contributor

Motivation for this change

Fixes DoS vulnerability CVE-2018-17144.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@roconnor
Copy link
Contributor Author

@jb55 Would you like to review this?

@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

This needs backporting to 18.09 because of the CVE fix.

@xeji xeji added this to the 18.09 milestone Sep 19, 2018
@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

18.03 (currenlty on 0.16.0) should also be upgraded to this.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

  CXX      bench/bench_bitcoin-verify_script.o
  CXX      bench/bench_bitcoin-base58.o
  CXX      bench/bench_bitcoin-lockedpool.o
  CXX      bench/bench_bitcoin-perf.o
  CXX      bench/bench_bitcoin-prevector_destructor.o
  CXX      bench/bench_bitcoin-coin_selection.o
  CXXLD    bench/bench_bitcoin
  GEN      qt/forms/ui_addressbookpage.h
building of '/nix/store/25zakwzgn7n5mww9720ywpkkyv5glfrg-bitcoin-0.16.3.drv' timed out after 3600 seconds
error: build of '/nix/store/25zakwzgn7n5mww9720ywpkkyv5glfrg-bitcoin-0.16.3.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

  CXX      test/test_bitcoin-amount_tests.o
  CXX      test/test_bitcoin-allocator_tests.o
  CXX      test/test_bitcoin-base32_tests.o
  CXX      test/test_bitcoin-base58_tests.o
  CXX      test/test_bitcoin-base64_tests.o
  CXX      test/test_bitcoin-bech32_tests.o
  CXX      test/test_bitcoin-bip32_tests.o
  CXX      test/test_bitcoin-blockchain_tests.o
building of '/nix/store/jh7sa8xzh0dmy5c29lvhvc1rxxqsj3b8-bitcoin-0.16.3.drv' timed out after 3600 seconds
error: build of '/nix/store/jh7sa8xzh0dmy5c29lvhvc1rxxqsj3b8-bitcoin-0.16.3.drv' failed

@roconnor
Copy link
Contributor Author

@AndersonTorres Would you like to review this?

@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

built on x86_64-linux locally, LGTM.

@xeji xeji merged commit fab901d into NixOS:master Sep 20, 2018
xeji pushed a commit that referenced this pull request Sep 20, 2018
@roconnor @xeji
bitcoin: 0.16.2 -> 0.16.3 (#46891)
40d22a7 
(cherry picked from commit fab901d)

security: fixes CVE-2018-17144
@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

backported to 18.09: 40d22a7

xeji pushed a commit that referenced this pull request Sep 20, 2018
@roconnor @xeji
bitcoin: 0.16.2 -> 0.16.3 (#46891)
6999bcc 
(cherry picked from commit fab901d)

security: fixes CVE-2018-17144
@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

backported to 18.03 in 4bb22be..6999bcc

@roconnor
Copy link
Contributor Author

@xeji Thanks for the help backporting. A version of bitcoin 0.15.2 has been tagged with a backported fix for this CVE for bitcoin 0.15. I noticed that NixOS 17.09 looks like it might still be receiving updates. Would you like me to make a patch upgrading to bitcoin to 0.15.2 on NixOS 17.09?

@roconnor roconnor deleted the bitcoin branch September 21, 2018 04:41
@xeji
Copy link
Contributor

xeji commented Sep 21, 2018

@roconnor 17.09 isn't officially supported anymore, and I'm not sure it's worth the effort because it already missed out on many security fixes on other packages. But if you think it's important feel free to push an update to 17.09.

@roconnor roconnor mentioned this pull request Sep 29, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roconnor @xeji @GrahamcOfBorg @jb55